Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify SMBIOS_080 for the case when there is no grouping #187

Closed
jhauser-us opened this issue Jul 30, 2024 · 3 comments
Closed

Clarify SMBIOS_080 for the case when there is no grouping #187

jhauser-us opened this issue Jul 30, 2024 · 3 comments
Assignees
@andreiw
Labels
fixed

Comments

@jhauser-us
Copy link

For SMBIOS_080, should a Group Associations structure be implemented even when there are no groupings of anything? (For example, if there is only one of everything: processor, hart, cache, etc.?)
@andreiw
Copy link
Collaborator

andreiw commented Aug 6, 2024

This is why it's should and not must. Do it unless there's a good reason not to. We could certainly conditionalize this.

@andreiw
Copy link
Collaborator

andreiw commented Aug 8, 2024

I'm actually tempted to just remove this requirement.

andreiw pushed a commit that referenced this issue Aug 8, 2024
ARC feedback on SMBIOS.
dba4c2f 
#185
#187

Signed-off-by: Andrei Warkentin <[email protected]>
@andreiw andreiw mentioned this issue Aug 8, 2024
Merged
@andreiw
Copy link
Collaborator

andreiw commented Aug 8, 2024

#195

andreiw pushed a commit that referenced this issue Aug 8, 2024
ARC feedback on SMBIOS.
5b06807 
#185
#187

Signed-off-by: Andrei Warkentin <[email protected]>
andreiw pushed a commit that referenced this issue Aug 8, 2024
ARC feedback on SMBIOS.
f493d96 
#185
#187

Signed-off-by: Andrei Warkentin <[email protected]>
@andreiw andreiw self-assigned this Aug 8, 2024
andreiw pushed a commit that referenced this issue Aug 8, 2024
ARC feedback on SMBIOS. (#195)
0d88c05 
#185
#187

Signed-off-by: Andrei Warkentin <[email protected]>
@andreiw andreiw closed this as completed Aug 8, 2024
@andreiw andreiw added the fixed label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreiw andreiw

Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreiw @jhauser-us