Strict mode + preparing for required authentication for database().search()

Author: bartve

HISTORY.md

@@ -1,3 +1,8 @@
+Unreleased
+==================
+  * Use `strict`
+  * Added local authentication check for the `database().search()` function
+
 0.3.4 / 2014-07-30
 ==================
   * Added `user().contributions()` and `user().submissions()` for the newly implemented endpoints

index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var discogs = module.exports = {};
 
 /**

lib/client.js

@@ -1,9 +1,11 @@
+'use strict';
+
 var http = require('http'),
 	zlib = require('zlib'),
 	url = require('url'),
 	queryString = require('querystring'),
 	OAuth = require('oauth-1.0a'),
-	package = require('../package.json'),
+	pkg = require('../package.json'),
 	error = require('./error.js'),
 	queue = require('./queue.js');
 
@@ -33,7 +35,7 @@ var config = {
 	customHeaders: {
 		'Accept': 'application/json; application/octet-stream',
 		'Accept-Encoding': 'gzip,deflate',
-		'User-Agent': 'DisConnectClient/'+package.version+' +'+package.homepage
+		'User-Agent': 'DisConnectClient/'+pkg.version+' +'+pkg.homepage
 	}
 };
 
@@ -147,7 +149,7 @@ DiscogsClient.prototype.identity = function(callback){
 
 DiscogsClient.prototype.about = function(callback){
 	this.get('', function(err, data){
-		if(data){ data.disconnect = { version: package.version, userAgent: (this.userAgent||config.customHeaders['User-Agent']) }; }
+		if(data){ data.disconnect = { version: pkg.version, userAgent: (this.userAgent||config.customHeaders['User-Agent']) }; }
 		(typeof callback === 'function')&&callback(err, data);
 	}); 
 };

lib/collection.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var util = require('./util.js'),
 	AuthError = require('./error.js').AuthError;
 

lib/database.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var util = require('./util.js'),
 	authError = require('./error.js').AuthError;
 
@@ -99,21 +101,25 @@ module.exports = function(client){
 	};
 
 	/**
-	 * Search the database
+	 * Search the database (requires authentication starting 2014-08-15)
 	 * @param {String} query - The search query
 	 * @param {Object} [params] - Search parameters as defined on http://www.discogs.com/developers/resources/database/search-endpoint.html
 	 * @param {Function} [callback] - Callback function
 	 */
 
 	database.search = function(query, params, callback){
-		var obj = {};
-		if(arguments.length <= 2){
-			(typeof params === 'function')&&(callback = params); // No extra search params, the callback is the second function param
+		if(client.authenticated()){
+			var obj = {};
+			if(arguments.length <= 2){
+				(typeof params === 'function')&&(callback = params); // No extra search params, the callback is the second function param
+			}else{
+				obj = params;
+			}
+			obj.q = util.escape(query);
+			client.get(util.addParams('/database/search', obj), callback);
 		}else{
-			obj = params;
+			callback(new AuthError());
 		}
-		obj.q = util.escape(query);
-		client.get(util.addParams('/database/search', obj), callback);
 	};
 
 	return database;

lib/error.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var Errors = module.exports = {};
 
 /**

lib/marketplace.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var util = require('./util.js'),
 	AuthError = require('./error.js').AuthError;
 

lib/queue.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var queue = module.exports = {},
 	DiscogsError = require('./error.js').DiscogsError,
 	stack = [],

lib/user.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var util = require('./util.js');
 
 module.exports = function(client){

lib/util.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var queryString = require('querystring');
 
 var util = module.exports = {};

lib/wantlist.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var util = require('./util.js'),
 	AuthError = require('./error.js').AuthError;