Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xss attacks has been executed #18

Open
SerikK opened this issue Sep 11, 2016 · 1 comment
Open

xss attacks has been executed #18

SerikK opened this issue Sep 11, 2016 · 1 comment

Comments

@SerikK
Copy link

SerikK commented Sep 11, 2016

Hi! I have detected that there is xss attack not prevented. I guess because of these code
`
$comments[$Comment->id] = $Comment->attributes;

$CommentListWidget
->getView()
->registerJs('jQuery("#' . $CommentListWidget->options['id'] . '").yiiCommentsList(' . Json::encode($comments) . ');');`
As can be seen from these codes there seems to be no encoding of each attributes in Comment object.

@rmrevin
Copy link
Owner

rmrevin commented Sep 12, 2016

Hi. Thanks for issue.
We need a unit test to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants