-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOES NOT WORK #48
Comments
Cannot confirm, works in our repo. Maybe there is something wrong with permissions in your workflow? Edit: broken in my repo as well now, same error as #48 (comment) |
I have significantly improved this in my fork; the changes can be found in PR #30: |
FWIW we're seeing this in workflow logs:
Looks like #49 was opened to address that. No updates to |
@jcogilvie Thanks for providing a fork 🙏🏼 I tried it but unfortunately it fails with INFO: Found no tfplan. Proceeding with input argument.
curl: (48) An unknown option was passed in to libcurl Here is the pipeline snippet - name: Comment Plan
uses: GetTerminus/terraform-pr-commenter@v2
with:
commenter_type: plan
commenter_input: ${{ format('{0}{1}', steps.plan.outputs.stdout, steps.plan.outputs.stderr) }}
commenter_exitcode: ${{ steps.plan.outputs.exitcode }}
terraform_version: 1.3.2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TF_IN_AUTOMATION: true
TF_WORKSPACE: ${{ matrix.workspace }} Do you've an idea what's cause the failing job? |
I'll have to update its base image. I think curl has changed out from under it. |
Okay, so the most straightforward fix is to use a newer I upgraded my workflows to pass in |
That did the trick 🙏🏼 |
I'm getting the following result:
I can not see any comments in my PR, This is how my gh action looks like:
Any ideas? |
Instead of a pulling a Docker-image every time, I took a stab at this in DevSecTop/TF-via-PR repository, which hosts a reusable workflow to run Terraform commands via PR comments, like a CLI. Although it doesn't have all the bells and whistles of terraform-pr-commenter (yet), it's a fair bit quicker; runs Terraform commands simultaneously in bulk; and, dynamically handles Terraform arguments (e.g., Here's an example of the workflow in action and how the output comments are formatted. |
Doesn't work, I see output saying it will create a comment for the plan but nothing appears.
The text was updated successfully, but these errors were encountered: