Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations imported to a custom list can end up in the wrong list #4

Open
kitschpatrol opened this issue Jan 24, 2023 · 2 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kitschpatrol
Copy link

kitschpatrol commented Jan 24, 2023

Thanks for an incredibly useful tool. I noticed one issue with a recent migration: Google doesn't seem to order custom lists consistently in the place labeling menu.

The built-in lists, "Favorites", "Want to go", "Travel Plans", and "Starred places" are reliably in positions 0–3, but beyond that if you have more than one custom list, you can't rely on Google to order them deterministically in the labeling menu. (I think they might bump the ordering of any custom lists of which the target location is already a member.)

For example:
Screenshot 2023-01-23 at 9 11 57 PMScreenshot 2023-01-23 at 9 12 10 PM

This can make a bit of a mess when migrating locations to a custom list, since your saved places are liable to end up across several custom lists instead of the intended target list.

To reproduce:

  1. Create two or more custom lists in your target account
  2. Run the migrator, e.g. gmigrate maps import-places -u lorem -p ipsum -f source.csv -l Custom -c 4
  3. Observe that the locations in your index file end up in multiple custom lists

Possible solution:
A menu-picking strategy based on matching the target label's name instead of its index would probably do the trick.

Would love to help with a PR but am swamped at the moment — still wanted to open this issue in case anyone else runs into it.

Note that if you have only one custom list in your account, the current implementation works fine since there's no chance it will be reordered at Google's whim.

@PaulRBerg
Copy link
Contributor

I think they might bump the ordering of any custom lists of which the target location is already a member

Can confirm this behavior.

I ran @robinnorth's tool over two saved lists, which contained quite a few duplicate places. The duplicated places have all failed to be saved in the second run.

Btw, Robin - thanks a lot for creating this!

@robinnorth
Copy link
Owner

Thanks @kitschpatrol for your detailed analysis of the issue, I agree that switching the custom list behaviour to use a string rather than list index is probably the way to go here.

@robinnorth robinnorth added bug Something isn't working help wanted Extra attention is needed labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants