-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"fatal error: concurrent map writes" or "fatal error: concurrent map read and map write" errors #737
Comments
Sounds like you're trying to mutate |
Well I'm using |
|
(fyi the above is from my helmfile build from the PR I submitted yesterday) The stack trace panic occurs AFTER all my releases are generated and printed to STDOUT (i.e. im in debug mode). |
does it generate the debug output list of generated releases via a single thread, but then when processing for real, does it concurrently? |
Ok here is a reproducible example: https://github.com/bitsofinfo/helmfile-737 |
Updated the example project, totally weird, especially the fatal error: concurrent map read and map write |
Thanks! Examples for reproduction are always helpful. This seems like happening due to that helmfile lazily and concurrently loads state values for rendering release values files.
|
i see the CI test failed, is this something i could run on my own? |
tried building locally and running, still getting the issue |
@bitsofinfo Thanks for testing! |
Sorry here you go Running https://github.com/bitsofinfo/helmfile-737
|
@bitsofinfo Would you mind adding the binary built from #706 to your This line contained in your logs seems to indicate that you're still using the binary from helmfile releases:
|
my bad, was referencing master... |
looks like
|
@bitsofinfo Are you sure you've run Anyways, I've rebased Try |
ok, now my build seems to work. sorry! late here.. |
and the example now no longer panics. thanks! |
Thanks for testing it out! I'll fix CI builds and report back when it gets released. // Actually the current implementation in the branch is wrong. as the fix would have a bad side-effect so I'll revise the implementation |
ok, any new commit you want me to test? |
@bitsofinfo I'd appreciate it if you could also test #741 out 😃 It fixes the same issue in an another way. |
Sry I meant #742 |
works! |
and.. #742 as well
|
also verified w/ my actual real use-case, works. Solid. Thank you for the attention to this, was a blocker! |
Glad to help, and thanks as always for your support I've just released v0.79.4 including the fix. |
great thanks man! |
It appears that when my helm does multiple sprig
merge
operations within arange
I get a panic exiting w/ the error"fatal error: concurrent map writes"
Masterminds/sprig#120
The text was updated successfully, but these errors were encountered: