Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add course roadmap #220

Draft
wants to merge 54 commits into
base: main
Choose a base branch
from
Draft

Add course roadmap #220

wants to merge 54 commits into from

Conversation

andreilgeorgescu
Copy link
Collaborator

@andreilgeorgescu andreilgeorgescu commented Dec 11, 2024 •
edited
Loading

Resolves #219

  • Install React Flow
  • Create DAG
    • Nodes
    • Edges
  • Business Logic
    • Map slug to title for label
    • Make links
    • Indicate optionality
    • Indicate difficulty
    • Highlight current course
  • Automate layout positioning
  • Legend for Difficulty and Optionality
  • Zoom
  • Create schema
  • Create content collections (@daniel-ciocirlan)
    • Kotlin
    • Scala
  • Create component
  • Integrate into course layout
  • Bugs
    • Instead of a Tree, it should be a DAG so the root can have siblings and courses can have multiple prerequisites.

@andreilgeorgescu andreilgeorgescu self-assigned this Dec 11, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 11, 2024 •
edited
Loading

Deploying rockthejvm-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6c88cb2
Status: ✅  Deploy successful!
Preview URL: https://1d6f06bb.rockthejvm-site.pages.dev
Branch Preview URL: https://issue219.rockthejvm-site.pages.dev

View logs

@andreilgeorgescu
Create placeholder roadmap component
2332b51
@andreilgeorgescu
Place placeholder component into temporary course layout section
7e4c257
@andreilgeorgescu
Update placeholder component
ba07c6d
@andreilgeorgescu
Only render roadmap on non-bundles
f1cf9bd
@andreilgeorgescu
Create prerequisites schema
943587e
@andreilgeorgescu
Make children property mandatory in CourseNode schema
b1f37df
@andreilgeorgescu
Add prerequisites schema to VSCode settings
ad7c2ad
@andreilgeorgescu
Add type annotation for connection parameter in onConnect callback
8e23eb1
@andreilgeorgescu
Add TreeNode interface to define tree structure
369fb5b
@andreilgeorgescu
Export TreeNode interface to make it accessible for external usage
166eb7a
@andreilgeorgescu
Remove TreeNode interface as it is no longer needed
b515f05
@andreilgeorgescu
Refactor prerequisites schema to use courseNode with updated structure
9c0b6be
@andreilgeorgescu
Update courseNode schema to reference courses instead of string value
c83f65c
@andreilgeorgescu
Add prerequisites collection to config
6fa042e
@andreilgeorgescu
Add Scala prerequisites content collection
20cdf41
@andreilgeorgescu
Refactor prerequisites schema to use a recursive treeNode structure
8b79c81
@andreilgeorgescu
Refactor scala.yaml
b15ad83
@andreilgeorgescu
Add Kotlin prerequisites content collection
a366cb4
@andreilgeorgescu
Enhance Scala prerequisites by adding additional topics and subtopics
e41eefe
@andreilgeorgescu
Add ZIO prerequisites content collection
1dd4c20
@andreilgeorgescu
Temporary disable roadmap
2304ac4
@andreilgeorgescu
Fix type checking issue in prerequisites schema
af7a5fc
@andreilgeorgescu
Map from Tree slug to Tree reactFlowEdge
ba0a998
@andreilgeorgescu
Natural transformation from Tree reactFlowEdge to List reactFlowEdge
0f6a7d5
@andreilgeorgescu
Refactor Roadmap component to use dynamic initial edges
657c7b7
@andreilgeorgescu
Update Roadmap component to accept dynamic initial nodes
548e293
@andreilgeorgescu
Add animated property to Edge interface and update initial node posit…
d64e1b5 
…ioning
@andreilgeorgescu
Fix some type errors
355c7a5
@andreilgeorgescu
Add @dagrejs/dagre package and update pnpm-lock.yaml
82b05de
@andreilgeorgescu
Auto layout roadmap
0574903
@andreilgeorgescu
Refactor prerequisites: add ZIO to Scala prerequisites and remove sta…
1ec6953 
…ndalone ZIO file
@andreilgeorgescu
Refactor prerequisites: update schema to be a DAG instead of a Tree
ba31d6a
@andreilgeorgescu
Add optional field to edgeSchema in prerequisites
8fe8364
@andreilgeorgescu
Set default value for optional field in edgeSchema to false
868d0a3
@andreilgeorgescu
Refactor Kotlin prerequisites: update structure to use nodes and edges
1cc2ab9
@andreilgeorgescu
Refactor Scala prerequisites: restructure to use nodes and edges
2c12a26
@andreilgeorgescu
Refactor Roadmap component: rename initialNodes and initialEdges prop…
f3afc81 
…s to nodes and edges
@andreilgeorgescu
Refactor Roadmap component: update nodes and edges props to use React…
dadfe4a 
…FlowNode and ReactFlowEdge types
@andreilgeorgescu
Refactor CourseLayout: update Roadmap component to use ReactFlowNode …
c9510cc 
…and ReactFlowEdge types
@andreilgeorgescu
Refactor roadmap and courselayout to use correct imports and props
d4aa3d8
@andreilgeorgescu
Refactor Roadmap component: integrate Dagre for layout calculations a…
8c1e749 
…nd update props handling
@andreilgeorgescu
Refactor Roadmap component: remove outdated comments in getLayoutedEl…
f35593c 
…ements function
@andreilgeorgescu
Refactor CourseLayout: update reactFlowNodes mapping to use async dat…
3f2259d 
…a retrieval for course titles
@andreilgeorgescu
Add MyLinkNode component: create a custom node for linking with style…
111e746 
…d anchor and handles
@andreilgeorgescu
Automatically call the layout upon page load
120546a
@andreilgeorgescu
Add MyLinkNode component and integrate it into CourseLayout for dynam…
a4048bb 
…ic linking
@andreilgeorgescu
Fix type errors
eb644d4
@andreilgeorgescu
Fix type errors
7379b7e
@andreilgeorgescu
Auto-detect which prerequisites roadmap is being used for each course
ad90eb0
@andreilgeorgescu
Remove layout buttons from roadmap
19f3ac0
@andreilgeorgescu
Add dynamic background color to MyLinkNode based on course difficulty
8474842
@andreilgeorgescu
Fix type errors
3a0badd
@andreilgeorgescu
Copy link
Collaborator Author

andreilgeorgescu commented Dec 20, 2024 •
edited
Loading

@daniel-ciocirlan How does this look so far? I only have Kotlin and Scala roadmaps but they cover everything. However, I imagine the hierarchy I created isn't completely correct.

I don't know why cloudflare isn't building again. On my end it seems to build and type check.
image
image

@daniel-ciocirlan
Copy link
Collaborator

@andreilgeorgescu I imagine the colors are by difficulty?

I just retried the build on this one, but it failed again:


14:33:27.306 | 12:33:27 ▶ src/pages/courses/[slug].astro
-- | --
14:33:27.894 | 12:33:27   ├─ /courses/advanced-kotlin.html (+587ms)
14:33:28.705 | 12:33:27   ├─ /courses/advanced-scala-old.html[TypeError] Cannot read properties of undefined (reading 'data')
14:33:28.706 | Hint:
14:33:28.706 | This issue often occurs when your MDX component encounters runtime errors.
14:33:28.706 | Stack trace:
14:33:28.706 | at file:///opt/buildhome/repo/dist/chunks/CourseLayout_B9xO7Eh4.mjs:587:19
14:33:28.706 | at async callComponentAsTemplateResultOrResponse (file:///opt/buildhome/repo/dist/chunks/astro/server_DdO40eNx.mjs:1043:25)
14:33:28.706 | at async renderJSXVNode (file:///opt/buildhome/repo/dist/chunks/astro/server_DdO40eNx.mjs:1844:21)
14:33:28.706 | at async Object.renderToStaticMarkup (file:///opt/buildhome/repo/dist/renderers.mjs:283:18)
14:33:28.706 | at async renderComponent (file:///opt/buildhome/repo/dist/chunks/astro/server_DdO40eNx.mjs:1743:10)
14:33:28.790 | ELIFECYCLE  Command failed with exit code 1.
14:33:28.820 | Failed: Error while executing user command. Exited with error code: 1
14:33:28.830 | Failed: build command exited with code: 1
14:33:30.019 | Failed: error occurred while running build command

@andreilgeorgescu
Copy link
Collaborator Author

Yes the colors are difficulty. Do you want a legend to be present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreilgeorgescu andreilgeorgescu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add course roadmap
2 participants
@andreilgeorgescu @daniel-ciocirlan