Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upload application docker image to dockerhub #18

Open
adityaprakash-bobby opened this issue Jun 23, 2022 · 5 comments
Open
Labels
good first issue Good for newcomers new feature Starting work on a new feature

Comments

@adityaprakash-bobby
Copy link
Member

adityaprakash-bobby commented Jun 23, 2022

It is good to have a workflow which publishes our application bundles into a docker image in dockerhub. On every successful release we can have the image pushed to public repository.

Refs:

@adityaprakash-bobby adityaprakash-bobby added good first issue Good for newcomers new feature Starting work on a new feature labels Jun 23, 2022
@pallasite99
Copy link
Member

Just some further info, this would involve:

  1. Manually testing a Dockerfile located at root repo
  2. Adding CI workflow for this Dockerfile in main

@shukra-in-spirit
Copy link
Contributor

Just some further info, this would involve:

  1. Manually testing a Dockerfile located at root repo
  2. Adding CI workflow for this Dockerfile in main

Further breaking down the first point made by Pallasite:

  1. Testing:

@pallasite99
Copy link
Member

pallasite99 commented Jul 15, 2022

@shukra-in-spirit I think it would also be a good idea to include support for multiple platforms here using qemu so that we are agnostic when it comes to building the docker image now or in the future.

Now, for the purpose of uploading image to Dockerhub ... it would be great if you can create an org account and have the settings to login protected by secrets similar to Sonar cloud setup. I believe that would be required before anyone starts working on this.

Till now, I've tested whether the base docker workflow works here with the current Dockerfile we have.

@pallasite99
Copy link
Member

For the container scanning part, this would roughly be the steps -

  1. Login to Dockerhub
  2. Configure Go
  3. Build the image
  4. Scan the image

ex:

- name: Scan image
      uses: Azure/container-scan@v0
      with:
        image-name: ${{ secrets.ACR_LOGIN_SERVER }}/spring-petclinic:${{ github.run_number }}
        severity-threshold: CRITICAL
        run-quality-checks: true

@shukra-in-spirit
Copy link
Contributor

I had created a docker organisation for us a while back. I will need to find out where it is. Will share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new feature Starting work on a new feature
Projects
None yet
Development

No branches or pull requests

3 participants