Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use igdb tag to set the IGDB ID from filename #1333

Open
taki-sahli opened this issue Dec 1, 2024 · 8 comments
Open

[Feature] Use igdb tag to set the IGDB ID from filename #1333

taki-sahli opened this issue Dec 1, 2024 · 8 comments
Labels
feature New feature or request

Comments

@taki-sahli
Copy link

Is your feature request related to a problem? Please describe.
Sometimes, RomM mismatch the game with the correct one in IGDB.

Describe the solution you'd like
To avoid mismatch of games with IGDB, we can use special tag igdb and set it from the filename.

Describe alternatives you've considered

Additional context
For example this game:

  • The correct match should:
    391319603-00c77ef4-4d7f-4059-9264-2d0f7338769b

  • But the result returned from IGDB gives this:
    391319534-ae16c487-e962-42e6-ae35-da1d239a9fd1

  • With this filename Inside [rev-10,igdb-7342].7z, there's no ambiguity.

@taki-sahli taki-sahli added the feature New feature or request label Dec 1, 2024
@InsertDisc
Copy link

Inside [rev-10] [igdb-7342].7z
This would would be nice, yes.

@gantoine
Copy link
Member

gantoine commented Jan 2, 2025

We're happy to support this, but we're not going to start changing filenames to append igdb-**** tags since it's not a common standard. So unless you want to go through and manually tag your files with their IGDB IDs I don't see how this would be a particularly useful feature.

@InsertDisc
Copy link

I think OP meant (correct me if I'm wrong) that if the tag was there then try to match using that instead of the filename. So yes, they'd be manually added by server admins.

@taki-sahli
Copy link
Author

Exactly:
if igdb-tag exists: use it directly
else normal behavior.
The main purpose of this tag, is the ability to fix ambiguity in the regular matcher.

@taki-sahli
Copy link
Author

An idea:
To ease setting it, when an admin uses manual match, at this moment, RomM can automatically add the IGDB ID tag.
image

@gantoine
Copy link
Member

gantoine commented Jan 2, 2025

RomM can automatically add the IGDB ID tag

We won't do that unless the community comes to a consensus that having the IGDB ID in the filename is good practice, like TVDB ID has been adopted by sonarr/radarr/jellyfin.

@InsertDisc
Copy link

I don't need the tag added by RomM, but the matching would be nice. I guess this is where OP and I differ.

@taki-sahli
Copy link
Author

I see, using the tag only will be enough for this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants