Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twig $property causes accidental property setting #22

Open
ljharb opened this issue Sep 2, 2013 · 2 comments
Open

twig $property causes accidental property setting #22

ljharb opened this issue Sep 2, 2013 · 2 comments

Comments

@ljharb
Copy link

ljharb commented Sep 2, 2013

When I try a git shortcut (in my gitconfig) like co for checkout, there are a few problems:

  • it doesn't perform a checkout
  • it sets a property called "co" on the current branch

This issue is that I think twig foo to set property "foo" is too implicit - twig set foo would be much clearer, and would allow for helpful error messages and extensions in the root namespace.

@rondevera
Copy link
Owner

Since reading and writing branch properties are two of the core functions of Twig, this usage most likely won't change. For each issue here:

  • Falling back to a Git subcommand is discussed in git config shortcuts don't work #23.
  • Setting a property could involve a prompt if the property doesn't exist yet. This'll get old pretty quickly, though.

@ljharb
Copy link
Author

ljharb commented Sep 3, 2013

A twig-config-opt-in setting to issue a prompt would work well. I use twig for reading properties exponentially more often than setting them, so that wouldn't be troublesome for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants