Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test scripts and CI after nerdctl v2.0 released #62

Closed
naoki9911 opened this issue Apr 1, 2024 · 1 comment · Fixed by #64
Closed

Update test scripts and CI after nerdctl v2.0 released #62

naoki9911 opened this issue Apr 1, 2024 · 1 comment · Fixed by #64
Assignees
@naoki9911

Comments

@naoki9911
Copy link
Collaborator

containerd/nerdctl#2906

In nerdctl v2, labels not passed through the OCI runtime since nerdctl v2.0, with an exception for nerdctl/bypass4netns.
We should migrate to --annotation (--annotation nerdctl/bypass4netns).
@naoki9911 naoki9911 self-assigned this Apr 1, 2024
@AkihiroSuda AkihiroSuda mentioned this issue Apr 3, 2024
Merged
@AkihiroSuda
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naoki9911 naoki9911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

--label -> --annotation AkihiroSuda/bypass4netns
2 participants
@AkihiroSuda @naoki9911