[ROOT-1030] Remove immutable fields from docs and payload, and add de…

…precation warning to Resource.
rootlyhq · Oct 24, 2024 · 4a68c23 · 4a68c23
1 parent 995a180
commit 4a68c23
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/client/roles.go b/client/roles.go
@@ -13,8 +13,6 @@ type Role struct {
 	Name string `jsonapi:"attr,name,omitempty"`
   Slug string `jsonapi:"attr,slug,omitempty"`
   IncidentPermissionSetId string `jsonapi:"attr,incident_permission_set_id,omitempty"`
-  IsDeletable *bool `jsonapi:"attr,is_deletable,omitempty"`
-  IsEditable *bool `jsonapi:"attr,is_editable,omitempty"`
   AlertsPermissions []interface{} `jsonapi:"attr,alerts_permissions,omitempty"`
   PulsesPermissions []interface{} `jsonapi:"attr,pulses_permissions,omitempty"`
   ApiKeysPermissions []interface{} `jsonapi:"attr,api_keys_permissions,omitempty"`

diff --git a/docs/resources/role.md b/docs/resources/role.md
@@ -35,8 +35,6 @@ description: |-
 - `incident_types_permissions` (List of String) Value must be one of `create`, `read`, `update`, `delete`.
 - `incidents_permissions` (List of String) Value must be one of `create`, `read`, `update`, `delete`.
 - `invitations_permissions` (List of String) Value must be one of `create`, `read`, `update`, `delete`.
-- `is_deletable` (Boolean) Whether the role can be deleted.. Value must be one of true or false
-- `is_editable` (Boolean) Whether the role can be edited.. Value must be one of true or false
 - `playbooks_permissions` (List of String) Value must be one of `create`, `read`, `update`, `delete`.
 - `private_incidents_permissions` (List of String) Value must be one of `create`, `read`, `update`, `delete`.
 - `pulses_permissions` (List of String) Value must be one of `create`, `update`, `read`.

diff --git a/provider/resource_role.go b/provider/resource_role.go
@@ -55,6 +55,7 @@ func resourceRole() *schema.Resource {
 				Required:    false,
 				Optional:    true,
 				Description: "Whether the role can be deleted.. Value must be one of true or false",
+				DeprecationMessage: "This resource is now ignored by the API, and will be removed in the next release.",
 			},
 
 			"is_editable": &schema.Schema{
@@ -63,6 +64,7 @@ func resourceRole() *schema.Resource {
 				Required:    false,
 				Optional:    true,
 				Description: "Whether the role can be edited.. Value must be one of true or false",
+				DeprecationMessage: "This resource is now ignored by the API, and will be removed in the next release.",
 			},
 
 			"alerts_permissions": &schema.Schema{