-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Four Axes TCP Robots #142
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Hmm I just noticed that the joint position read for the linear axis, ie, Here's the printout of the value of all the joint positions obtained from the incoming protobuf msg. ie
The value at index 2 , Does this mean the EGM client on the robot is not publishing the right joint position? |
* Estimate linear joint value from cartesian pose Signed-off-by: Yadunund <[email protected]> * Cleanup Signed-off-by: Yadunund <[email protected]> * Define constants Signed-off-by: Yadunund <[email protected]>
Managed to overcome the issue above with 60bcc39 which updates the protobuf parsing to compensate for this error by deriving the correct value from the cartesian Z-value of the robot. Tested this out with the same IRB910SC in RobotStudio and seems to work well. Notice how the linear axis moves this time in the robot state visualization in RViz. In the video in the PR description, the axis doesn't move due to the protobuf error in the input joint value. abb_libegm_scara_fixed.mp4 |
Update: I've been using these changes to command a physical irb910sc robot for a few months without any issues. |
@gavanderhoorn could you provide some feedback on this PR? |
@gavanderhoorn another ping. |
This PR extends EGM support to four axis robots such as the
ABB IRB910SC
. It fixes #141I've tested this with an
IRB910SC
robot inRobotStudio
usingabb_egm_rws_managers
and theabb_ros2
driver fromPickNik
. Will be opening PRs in those repositories with supporting changes. But the changes here will need to be merged in first.abb_libegm_scara_demo.mp4