Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ROS_DISTRO=false #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support ROS_DISTRO=false #834

wants to merge 1 commit into from

Conversation

mathias-luedtke
Copy link
Member

No description provided.

@mathias-luedtke mathias-luedtke mentioned this pull request Jun 2, 2023
Open
@mathias-luedtke mathias-luedtke force-pushed the feature/rosdistro-false branch from 8d10449 to b08fd05 Compare June 2, 2023 19:50
@mathias-luedtke mathias-luedtke marked this pull request as ready for review June 3, 2023 11:13
@mathias-luedtke
Copy link
Member Author

@marip8: please test it

@marip8
Copy link
Member

marip8 commented Jun 5, 2023 •
edited
Loading

Output from the opw_kinematics test PR. Looks like PYTHON_VERSION_NAME needs to be set

image

@mathias-luedtke mathias-luedtke force-pushed the feature/rosdistro-false branch from b08fd05 to a6e1f7c Compare June 6, 2023 22:10
@mathias-luedtke
Copy link
Member Author

Looks like PYTHON_VERSION_NAME needs to be set

Good catch!
I have not tested it with DOCKER_IMAGE.
I removed the special handling, lets see if the tests pass..

@marip8
Copy link
Member

marip8 commented Jun 7, 2023

Now it looks like the ROS_VERSION_EOL variable also needs to be set.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathias-luedtke @marip8