[global_planner] tolerance implementation #1041
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the tolerance param which was never used.
See #262, #703 and #1040
First naive and not so optimized implementation which checks validity using
calculatePotentials
after filtering out lethal cells (so potentially CPU heavy for large tolerance).Alternatively, a check for the cells value could be used without using
calculatePotentials
, or also filtering inscribed or even circumscribed cells. I am up for the debate.