Skip to content

Commit f07d63a

Browse files
committed
addressing review comments
1 parent fa79f95 commit f07d63a

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

rep-0008.rst

+6-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ With ``catkin``
3131
The loader method of accessing Python code in ROS is obsolete if you are using
3232
``catkin``.
3333
When using ``catkin``, the Python code for all packages will be on the
34-
``PYTHONPATH`` after sourcing the `setup.bash` file for your workspace.
34+
``PYTHONPATH`` after sourcing the ``setup`` file for your workspace.
3535

3636
With ``rosbuild``
3737
-----------------
@@ -98,7 +98,7 @@ If your package contains messages or services then they will generate code into
9898
Though this generated code does not go into your package's source code, it does get merged with your package's Python source when getting installed.
9999
This is a new mechanism introduced with ``catkin`` because ``catkin`` installs into a FHS [5]_ layout, whereas ``rosbuild`` did not have an install step.
100100

101-
Your package shares a global ``PYTHONPATH`` namespace with other packages, so be considerate when creating Python packages at the root of your package's ``src`` folder as they can collide with others.
101+
Your package shares a global ``PYTHONPATH`` namespace with other packages (system Python packages as well as ROS packages with Python code), so be considerate when creating Python packages at the root of your package's ``src`` folder as they can collide with others.
102102

103103
Installing Scripts with catkin
104104
''''''''''''''''''''''''''''''
@@ -232,7 +232,7 @@ The target version of Python changes based on the requirements for each distribu
232232
See REP-0003 [2]_ for the target Python version for each ROS distribution.
233233

234234
Currently, as of 2015, the target is Python 2.7+, but we wish to encourage
235-
code that is easily transitioned to Python 3 [3]_.
235+
code that is easily transitioned to Python 3 [3]_ [6]_.
236236

237237
This means you should follow the recommended guidelines on the ROS wiki:
238238

@@ -256,6 +256,9 @@ References
256256
.. [5] Wikipedia: Filesystem Hiearchy Standard
257257
http://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard
258258
259+
.. [6] ROS Python 2/3 Compatibility Guidelines
260+
http://wiki.ros.org/python_2_and_3_compatible_code
261+
259262
Copyright
260263
=========
261264

0 commit comments

Comments
 (0)