Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings #172

Open
chapulina opened this issue Aug 13, 2018 · 2 comments
Open

Deprecation warnings #172

chapulina opened this issue Aug 13, 2018 · 2 comments

Comments

@chapulina
Copy link

According to the wiki page:

Migration: Since ROS Hydro, tf has been "deprecated" in favor of tf2. tf2 is an iteration on tf providing generally the same feature set more efficiently. ... tf will continue to be supported for through at least J Turtle.

How about adding deprecation warnings to all the code in this repo?

I'd also suggest adding a README file with a warning and a link to the new recommended packages.

@tfoote
Copy link
Member

tfoote commented Aug 16, 2018

That warning on the wiki page comes from the package.xml in the root of the package:

<p><b>Migration</b>: Since ROS Hydro, tf has been "deprecated" in favor of <a href = "http://wiki.ros.org/tf2">tf2</a>. tf2 is an iteration on tf providing generally the same feature set more efficiently. As well as adding a few new features.<br/>

We've been doing a soft deprecation since now it's only an API wrapper on the new implementation. Maintaining the wrapper isn't too much work and there's still a lot of code using it. Now that we're past J turtle we could start more actively deprecating it. Targeting N-Turtle for deprecation with lots of compiler warnings and removal in O turtle might make sense.

@mortenfyhn
Copy link

How about modifying the repo description or adding a readme file that clearly states that the geometry2 repo should be preferred? It's easy to arrive here from a web search, find a header file with some useful stuff, and start using for instance this repo's eigen_conversions instead of geometry2's tf2_eigen, and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants