Use BOOST_FOREACH and take publisher by const ref.

Author: efernandez

nodelet_topic_tools/include/nodelet_topic_tools/nodelet_lazy.h

@@ -41,6 +41,7 @@
 #include <ros/ros.h>
 #include <nodelet/nodelet.h>
 #include <image_transport/image_transport.h>
+#include <boost/foreach.hpp>
 #include <boost/thread.hpp>
 #include <string>
 #include <vector>
@@ -145,9 +146,8 @@ class NodeletLazy: public nodelet::Nodelet
     if (lazy_)
     {
       boost::mutex::scoped_lock lock(connection_mutex_);
-      for (size_t i = 0; i < publishers_.size(); i++)
+      BOOST_FOREACH (const ros::Publisher& pub, publishers_)
       {
-        ros::Publisher pub = publishers_[i];
         if (pub.getNumSubscribers() > 0)
         {
           if (connection_status_ != SUBSCRIBED)
@@ -166,9 +166,8 @@ class NodeletLazy: public nodelet::Nodelet
           return;
         }
       }
-      for (size_t i = 0; i < image_transport_publishers_.size(); i++)
+      BOOST_FOREACH (const image_transport::Publisher& pub, image_transport_publishers_)
       {
-        image_transport::Publisher pub = image_transport_publishers_[i];
         if (pub.getNumSubscribers() > 0)
         {
           if (connection_status_ != SUBSCRIBED)