Use const reference for std::string

efernandez · efernandez · commit d1ff6a7c72c2 · 2018-05-03T13:33:26.000-04:00
diff --git a/nodelet_topic_tools/include/nodelet_topic_tools/nodelet_lazy.h b/nodelet_topic_tools/include/nodelet_topic_tools/nodelet_lazy.h
@@ -232,7 +232,7 @@ class NodeletLazy: public nodelet::Nodelet
     */
   template<class T> ros::Publisher
   advertise(ros::NodeHandle& nh,
-            std::string topic, int queue_size, bool latch=false)
+            const std::string& topic, int queue_size, bool latch=false)
   {
     boost::mutex::scoped_lock lock(connection_mutex_);
     ros::SubscriberStatusCallback connect_cb

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ class NodeletLazy: public nodelet::Nodelet`
`232`	`232`	`*/`
`233`	`233`	`template<class T> ros::Publisher`
`234`	`234`	`advertise(ros::NodeHandle& nh,`
`235`		`- std::string topic, int queue_size, bool latch=false)`
	`235`	`+ const std::string& topic, int queue_size, bool latch=false)`
`236`	`236`	`{`
`237`	`237`	`boost::mutex::scoped_lock lock(connection_mutex_);`
`238`	`238`	`ros::SubscriberStatusCallback connect_cb`