Skip to content

Commit b0f0aa2

Browse files
morlov-apexaijmachowinski
authored andcommitted
Add compression_threads_priority to the node params parser
Signed-off-by: Michael Orlov <[email protected]>
1 parent ed3d4e4 commit b0f0aa2

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

rosbag2_transport/src/rosbag2_transport/config_options_from_node_params.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,10 @@ RecordOptions get_record_options_from_node_params(rclcpp::Node & node)
235235
node, "record.compression_threads", 0, std::numeric_limits<int64_t>::max(),
236236
record_options.compression_threads);
237237

238+
record_options.compression_threads_priority = param_utils::declare_integer_node_params<int32_t>(
239+
node, "record.compression_threads_priority", std::numeric_limits<int32_t>::min(),
240+
std::numeric_limits<int32_t>::max(), record_options.compression_threads_priority);
241+
238242
std::string qos_profile_overrides_path =
239243
node.declare_parameter<std::string>("record.qos_profile_overrides_path", "");
240244

rosbag2_transport/test/resources/recorder_node_params.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ recorder_params_node:
1818
compression_format: "h264"
1919
compression_queue_size: 10
2020
compression_threads: 2
21+
compression_threads_priority: -1
2122
qos_profile_overrides_path: ""
2223
include_hidden_topics: true
2324
include_unpublished_topics: true

rosbag2_transport/test/rosbag2_transport/test_composable_recorder.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ TEST_P(ComposableRecorderTests, recorder_can_parse_parameters_from_file) {
220220
EXPECT_EQ(record_options.compression_format, "h264");
221221
EXPECT_EQ(record_options.compression_queue_size, 10);
222222
EXPECT_EQ(record_options.compression_threads, 2);
223+
EXPECT_EQ(record_options.compression_threads_priority, -1);
223224
std::unordered_map<std::string, rclcpp::QoS> topic_qos_profile_overrides{
224225
std::pair{
225226
"/overrided_topic_qos",

0 commit comments

Comments
 (0)