IOIOLib: Make Android IOIOService reliable

Previously, a IOIOService would not correctly recover from a disconnect/
reconnect in the case of AOA. This change addresses this problem by
forwarding all connection events through a hidden activity.

Author: ytai

software/IOIOLib/target/android/src/ioio/lib/util/android/IOIOService.java

@@ -1,17 +1,17 @@
 /*
  * Copyright 2011 Ytai Ben-Tsvi. All rights reserved.
- *  
- * 
+ *
+ *
  * Redistribution and use in source and binary forms, with or without modification, are
  * permitted provided that the following conditions are met:
- * 
+ *
  *    1. Redistributions of source code must retain the above copyright notice, this list of
  *       conditions and the following disclaimer.
- * 
+ *
  *    2. Redistributions in binary form must reproduce the above copyright notice, this list
  *       of conditions and the following disclaimer in the documentation and/or other materials
  *       provided with the distribution.
- * 
+ *
  * THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
  * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ARSHAN POURSOHI OR
@@ -21,7 +21,7 @@
  * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- * 
+ *
  * The views and conclusions contained in the software and documentation are those of the
  * authors and should not be interpreted as representing official policies, either expressed
  * or implied.
@@ -36,7 +36,7 @@
 
 /**
  * A convenience class for easy creation of IOIO-based services.
- * 
+ *
  * It is used by creating a concrete {@link Service} in your application, which
  * extends this class. This class then takes care of proper creation and
  * abortion of the IOIO connection and of a dedicated thread for IOIO
@@ -99,9 +99,7 @@ private void start(Intent intent) {
 			helper_.start();
 			started_ = true;
 		} else {
-			if ((intent.getFlags() & Intent.FLAG_ACTIVITY_NEW_TASK) != 0) {
-				helper_.restart();
-			}
+			helper_.restart();
 		}
 	}
 
@@ -147,7 +145,7 @@ protected void stop() {
 	 * IOIO. In multi-IOIO scenarios, where you want to identify which IOIO the
 	 * thread is for, consider overriding
 	 * {@link #createIOIOLooper(String, Object)} instead.
-	 * 
+	 *
 	 * @return An implementation of {@link IOIOLooper}, or <code>null</code> to
 	 *         skip.
 	 */

software/applications/HelloIOIOService/AndroidManifest.xml

@@ -7,7 +7,13 @@
 		android:label="@string/app_name">
 		<uses-library android:name="com.android.future.usb.accessory"
 			android:required="false" />
-		<service android:name="HelloIOIOService">
+		<service android:name="HelloIOIOService" />
+		<activity android:label="@string/app_name" android:name="MainActivity"
+			android:launchMode="singleTask">
+			<intent-filter>
+				<action android:name="android.intent.action.MAIN" />
+				<category android:name="android.intent.category.LAUNCHER" />
+			</intent-filter>
 			<intent-filter>
 				<action android:name="android.hardware.usb.action.USB_ACCESSORY_ATTACHED" />
 			</intent-filter>
@@ -18,14 +24,6 @@
 				android:resource="@xml/accessory_filter" />
 			<meta-data android:name="android.hardware.usb.action.USB_DEVICE_ATTACHED"
 				android:resource="@xml/device_filter" />
-
-		</service>
-		<activity android:label="@string/app_name" android:name="MainActivity"
-			android:launchMode="singleTask">
-			<intent-filter>
-				<action android:name="android.intent.action.MAIN" />
-				<category android:name="android.intent.category.LAUNCHER" />
-			</intent-filter>
 		</activity>
 	</application>
 </manifest>

software/applications/HelloIOIOService/src/ioio/examples/hello_service/HelloIOIOService.java

@@ -1,16 +1,16 @@
 package ioio.examples.hello_service;
 
-import android.app.Notification;
-import android.app.NotificationManager;
-import android.app.PendingIntent;
-import android.content.Intent;
-import android.os.IBinder;
 import ioio.lib.api.DigitalOutput;
 import ioio.lib.api.IOIO;
 import ioio.lib.api.exception.ConnectionLostException;
 import ioio.lib.util.BaseIOIOLooper;
 import ioio.lib.util.IOIOLooper;
 import ioio.lib.util.android.IOIOService;
+import android.app.Notification;
+import android.app.NotificationManager;
+import android.app.PendingIntent;
+import android.content.Intent;
+import android.os.IBinder;
 
 /**
  * An example IOIO service. While this service is alive, it will attempt to
@@ -41,8 +41,8 @@ public void loop() throws ConnectionLostException,
 	}
 
 	@Override
-	public void onStart(Intent intent, int startId) {
-		super.onStart(intent, startId);
+	public int onStartCommand(Intent intent, int flags, int startId) {
+		int result = super.onStartCommand(intent, flags, startId);
 		NotificationManager nm = (NotificationManager) getSystemService(NOTIFICATION_SERVICE);
 		if (intent != null && intent.getAction() != null
 				&& intent.getAction().equals("stop")) {
@@ -61,6 +61,7 @@ public void onStart(Intent intent, int startId) {
 			notification.flags |= Notification.FLAG_ONGOING_EVENT;
 			nm.notify(0, notification);
 		}
+		return result;
 	}
 
 	@Override