Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance on GH actions #834

Closed
wants to merge 1 commit into from
Closed

Maintenance on GH actions #834

wants to merge 1 commit into from

Conversation

juliasilge
Copy link
Member

Mainly trying to solve this failure on #832:

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-board_url.R:76:3'): can download pin from board_folder version dir ──
Error in `self$start()`: webfakes app subprocess did not start :(
Backtrace:
    ▆
 1. ├─pins::board_url(c(x = board_fake$url())) at test-board_url.R:76:3
 2. │ └─pins:::get_url_format(urls)
 3. │   └─rlang::is_scalar_character(urls)
 4. │     └─rlang::is_character(x, n = 1L)
 5. └─board_fake$url()
 6.   └─self$start()
── Error ('test-board_url.R:94:3'): can download pin from versioned board_folder ──
Error in `self$start()`: webfakes app subprocess did not start :(
Backtrace:
    ▆
 1. ├─pins::board_url(b1_process$url()) at test-board_url.R:94:3
 2. │ └─pins:::get_url_format(urls)
 3. │   └─rlang::is_scalar_character(urls)
 4. │     └─rlang::is_character(x, n = 1L)
 5. └─b1_process$url()
 6.   └─self$start()
── Error ('test-board_url.R:111:3'): pin_meta() works for versioned board ──────
Error in `self$start()`: webfakes app subprocess did not start :(
Backtrace:
    ▆
 1. ├─pins::board_url(b1_process$url()) at test-board_url.R:111:3
 2. │ └─pins:::get_url_format(urls)
 3. │   └─rlang::is_scalar_character(urls)
 4. │     └─rlang::is_character(x, n = 1L)
 5. └─b1_process$url()
 6.   └─self$start()
── Error ('test-board_url.R:137:3'): useful error for missing or unparseable manifest file ──
Error in `self$start()`: webfakes app subprocess did not start :(
Backtrace:
     ▆
  1. ├─testthat::expect_error(board_url(b2$url()), "Failed to access manifest file") at test-board_url.R:137:3
  2. │ └─testthat:::expect_condition_matching(...)
  3. │   └─testthat:::quasi_capture(...)
  4. │     ├─testthat (local) .capture(...)
  5. │     │ └─base::withCallingHandlers(...)
  6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
  7. ├─pins::board_url(b2$url())
  8. │ └─pins:::get_url_format(urls)
  9. │   └─rlang::is_scalar_character(urls)
 10. │     └─rlang::is_character(x, n = 1L)
 11. └─b2$url()
 12.   └─self$start()

@olivroy
Copy link
Contributor

olivroy commented Jun 11, 2024

It is safe to commit this! I saw that the new coverage action sometimes fails on the first try, but works the following times

@juliasilge
Copy link
Member Author

This failure is definitely unrelated to your work @olivroy. 👍

There is apparently a new problem with webfakes (which pins uses for testing) on the test coverage PR. I'm going to see if I can figure it out quickly, but if not, I'll merge your PR as is and just live with the test coverage failure for now.

@juliasilge
Copy link
Member Author

Closing this as we watch for the fix in r-lib/webfakes#103

@juliasilge juliasilge closed this Aug 2, 2024
@juliasilge juliasilge deleted the update-gh-actions branch August 2, 2024 16:21
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants