Error when deleting last version of a pin

[MichalLauer]

Hello,

Thanks for this great package!

I am uploading custom files to a local board. However, there is an error thrown whenever I

1. create a board and a pin,
2. upload a file using pin_upload(),
3. remove that pin, and
4. try to upload a new one.

Here is a custom reprex that replicates this issue:

library(pins)
#> Warning: package 'pins' was built under R version 4.3.3

# Prepare data
write.csv(mtcars, file = "mtcars.csv")

# Create temp board and first upload
board <- board_temp(versioned = TRUE)
pin_upload(board = board, paths = "mtcars.csv", name = "data")
#> Creating new version '20240824T203215Z-cd94d'

# Delete just created pin
latest_version <- pin_versions(board = board, name = "data")$version
pin_version_delete(board = board, name = "data", version = latest_version)

# Upload new data
pin_upload(board = board, paths = "mtcars.csv", name = "data")
#> Error in versions$version[[1]]: subscript out of bounds

I think the issue happens within the version_setup() on line 162:

pins-r/R/pin_versions.R

Lines 160 to 171 in 2edcccb

	if (pin_exists(board, name)) {
	versions <- pin_versions(board, name)
	old_version <- versions$version[[1]]
	n_versions <- nrow(versions)
	if (old_version == new_version) {
	cli::cli_abort(c(
	"The new version {.val {new_version}} is the same as the most recent version.",
	i = "Did you try to create a new version with the same timestamp as the last version?"
	),
	call = call)
	}
	} else {

because in that state, the board exists without any pins (and hence without any versions).

Could a simple fix be just a check in the if statement?

if (pin_exists(board, name) & length(versions) > 0) {
  ...
}

If so, happy to do a PR :) Thanks!

[juliasilge]

Thanks so much for this report! I believe you have diagnosed the problem correctly, yes.

I don't think we can do if (pin_exists(board, name) & length(versions) > 0) because we can't do pin_versions() until we know the pin exists, but we can add an additional check inside the if statement, or maybe add a new little helper which could be called in the if statement after the currently existing part:

pin_version_exists <- function(board, name) {
  versions <- pin_versions(board, name)
  length(versions) > 0
}

We would welcome a PR with one of these fixes if you are interested! 🙌

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.