Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable cache on local board #840

Open
wklimowicz opened this issue Sep 6, 2024 · 1 comment
Open

Can't enable cache on local board #840

wklimowicz opened this issue Sep 6, 2024 · 1 comment
Labels
feature a feature request or enhancement

Comments

@wklimowicz
Copy link

First off, thanks for your work on this package!

I'm in the same situation as #669, where I want to enable caching for a slow network drive. The two functions suggested in #669 create a board, and create a folder inside ~/.cache/pins/, but the cache doesn't populate with any files. I've created a reprex repo here with a GitHub action showing that no file get's created after pin_read. Am I misunderstanding when the caching is intended to happen?

https://github.com/wklimowicz/pins-bug-no-cache/

image

@juliasilge
Copy link
Member

Oh yes, you are definitely right. Adding a cache path to the board isn't the only thing that needs to happen. What I said here about this just working is definitely wrong. I'm not sure why I thought that. Apologies to both you and the original poster!

Instead, what we would need to do is to set up board_folder() to act more like board_url(), for example, the caching that is implemented in http_download() here:

http_download <- function(url, path_dir, path_file, ...,

I'll mark this as a feature request once more and we can again collect feedback on it. Thanks for your understanding!

@juliasilge juliasilge added the feature a feature request or enhancement label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants