You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's easy to miss the staticimport checks since you have to look at a PR in just the right way to find them. That makes sense for normal day-to-day checks, but I think it's worth considering making it an error in the rc- branch so that we don't forget to update them.
The checks as they are now wouldn't trigger an error or message unless a function currently being statically imported was updated, and we usually have a reason for updating those static imports... so we should probably update them before pushing out a new release.
The text was updated successfully, but these errors were encountered:
It's easy to miss the
staticimport
checks since you have to look at a PR in just the right way to find them. That makes sense for normal day-to-day checks, but I think it's worth considering making it an error in therc-
branch so that we don't forget to update them.The checks as they are now wouldn't trigger an error or message unless a function currently being statically imported was updated, and we usually have a reason for updating those static imports... so we should probably update them before pushing out a new release.
The text was updated successfully, but these errors were encountered: