Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticimport checks should error in rc-v* branches #27

Open
gadenbuie opened this issue Aug 12, 2023 · 1 comment
Open

staticimport checks should error in rc-v* branches #27

gadenbuie opened this issue Aug 12, 2023 · 1 comment

Comments

@gadenbuie
Copy link
Member

It's easy to miss the staticimport checks since you have to look at a PR in just the right way to find them. That makes sense for normal day-to-day checks, but I think it's worth considering making it an error in the rc- branch so that we don't forget to update them.

The checks as they are now wouldn't trigger an error or message unless a function currently being statically imported was updated, and we usually have a reason for updating those static imports... so we should probably update them before pushing out a new release.

@gadenbuie
Copy link
Member Author

Related: we could also adopt a policy of adding a release bullet to remind us via use_release_issue(). I added this in promises

release_bullets <- function() {
  c(
    "Update staticimports: `staticimports::import()`"
  )
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant