Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artifacts aren't accessible on "first clean run" #5

Open
cpsievert opened this issue Nov 15, 2022 · 0 comments
Open

artifacts aren't accessible on "first clean run" #5

cpsievert opened this issue Nov 15, 2022 · 0 comments

Comments

@cpsievert
Copy link
Contributor

cpsievert commented Nov 15, 2022 •
edited
Loading

Currently they are only uploaded on failure, which is problematic for checking in "good" _snaps test results for the 1st time (that said, it is possible to workaround this problem by introducing a failure)

shiny-workflows/.github/workflows/R-CMD-check.yaml

Lines 174 to 179 in 1e30e3d

- name: "Upload 'Check package' results"
if: failure()
uses: actions/upload-artifact@main
with:
name: ${{ matrix.config.os }}-r${{ matrix.config.r }}-results
path: "check"

@cpsievert cpsievert changed the title upload-artifacts should always be uploaded (or at least when changes have been made to the _snaps) folder artifacts aren't accessible on "first clean run" Nov 15, 2022
@cpsievert cpsievert mentioned this issue Dec 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpsievert