Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php Unit test case setup #60

Open
DevikVekariya opened this issue Jan 14, 2020 · 9 comments
Open

Php Unit test case setup #60

DevikVekariya opened this issue Jan 14, 2020 · 9 comments
Assignees

Comments

@DevikVekariya
Copy link
Member

  • Create a setup for Php Unit Tests along with the documentation.

Acceptance Criteria:

  • Each class and its method should pass though the Php Unit test case
  • If any of the methods are ignored then, it should have proper docs with a reason to ignore it.
  • It should have detailed documentation for the local setup of Unit tests and how to run it locally.

Can take a reference from here - rtCamp/login-with-google#19

@dishitpala
Copy link
Member

dishitpala commented Jan 14, 2020

@DevikVekariya
I need 24hrs to complete the task
Which includes learning and implementation
There is 3 different classes with 17 unique functions
The test will cover all the classes and the functions

Time estimation may vary because I will be starting learning as well as implementation completely from scratch

@DevikVekariya
Copy link
Member Author

DevikVekariya commented Jan 22, 2020

@dishitpala I wanted to split this issue between multiple folks.

  • Create a new branch dev-unit-test from master.
  • Create a new branch from the dev-unit-test to write the test case
  • Setup the unit tests setup from reference Fixes #16 Unit test cases for plugin login-with-google#19
  • Raise the PR from your test-case branch to dev-unit-test
  • Make sure that we'll have one PR from dev-unit-test to master for all together

Assign PRs to @deepaklalwani97 for the Review

@thrijith
Copy link

@deepaklalwani97 Please review and merge #63 if it looks ok to you. Thanks

@thrijith
Copy link

The setup has been merged into https://github.com/rtCamp/amp-admanager/tree/dev-unit-test, tests for each classes can now be created from that branch as base.

@thrijith
Copy link

Added case for classes/admin.php in https://github.com/rtCamp/amp-admanager/blob/add/admin-class-tests/tests/classes/test-class-admin.php, working on classes/shortcode.php currently.

@thrijith
Copy link

Done with assigned classes for the plugin.
cc: @DevikVekariya @maitreyie-chavan

@vaishaliagola27
Copy link

Added test case for classes/amp-admanager.php
Please review #71.

@vaishaliagola27
Copy link

@DevikVekariya I've merged PR related to classes/amp-admanager.php tests.

@deepaklalwani97
Copy link
Member

@juhi123 We have added unit tests for this repo in dev-unit-test and the branch needs to be QA tested before we can merge it. Please follow the readme and test the dev-unit-test branch.

@thrijith thrijith removed their assignment Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants