Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpcs pipeline to the project #66

Closed
2 tasks done
DevikVekariya opened this issue Jan 29, 2020 · 4 comments
Closed
2 tasks done

Add phpcs pipeline to the project #66

DevikVekariya opened this issue Jan 29, 2020 · 4 comments
Assignees

Comments

@DevikVekariya
Copy link
Member

DevikVekariya commented Jan 29, 2020

Add pipeline with needful phpcs checks

Seems necessary from this => #63 (comment)

@thrijith
Copy link

@DevikVekariya @kiranpotphode The project needs a PHPCS ruleset as well, apart from the workflow, for exclusion of test files from PHPCS checking.

@kiranpotphode
Copy link
Member

@DevikVekariya PHPCS GH action is already configured. Added the phpcs.xml file and excluded the tests folder from the scan

@kiranpotphode
Copy link
Member

PR for this
#67

thrijith added a commit that referenced this issue Jan 30, 2020
@kiranpotphode
Copy link
Member

@DevikVekariya This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants