From c72d751a579a04ea6780e25ae5da2427c990544c Mon Sep 17 00:00:00 2001 From: Martin Emde Date: Sun, 1 Dec 2024 11:59:24 -0800 Subject: [PATCH] fix rubocop problems in event previews --- .../version/pushed_component_preview.rb | 23 ++++++---------- .../yank_forbidden_component_preview.rb | 26 +++++++------------ .../version/yanked_component_preview.rb | 23 ++++++---------- 3 files changed, 25 insertions(+), 47 deletions(-) diff --git a/test/components/previews/events/rubygem_event/version/pushed_component_preview.rb b/test/components/previews/events/rubygem_event/version/pushed_component_preview.rb index 2615ea62355..5b3d108a0f1 100644 --- a/test/components/previews/events/rubygem_event/version/pushed_component_preview.rb +++ b/test/components/previews/events/rubygem_event/version/pushed_component_preview.rb @@ -1,19 +1,12 @@ class Events::RubygemEvent::Version::PushedComponentPreview < Lookbook::Preview - def default(rubygem: Rubygem.first!, # rubocop:disable Metrics/ParameterLists - number: "1.0.0", platform: "ruby", - version_gid: rubygem.versions.where(number:, platform:).first&.to_gid, - pushed_by: "Pusher", actor_gid: version_gid&.find&.pusher&.to_gid) - event = FactoryBot.build(:events_rubygem_event, rubygem:, tag: Events::RubygemEvent::VERSION_PUSHED, additional: - { - number:, - platform:, - pushed_by:, + def default(rubygem: Rubygem.first!, **additional) + additional[:number] ||= "1.0.0" + additional[:platform] ||= "ruby" + additional[:version_gid] ||= rubygem.versions.where(number:, platform:).first&.to_gid + additional[:pushed_by] ||= "Pusher" + additional[:actor_gid] ||= version_gid.find.pusher.to_gid if additional[:version_gid] - version_gid:, - actor_gid: - }) - render Events::RubygemEvent::Version::PushedComponent.new( - event: - ) + event = FactoryBot.build(:events_rubygem_event, rubygem:, tag: Events::RubygemEvent::VERSION_PUSHED, additional:) + render Events::RubygemEvent::Version::PushedComponent.new(event:) end end diff --git a/test/components/previews/events/rubygem_event/version/yank_forbidden_component_preview.rb b/test/components/previews/events/rubygem_event/version/yank_forbidden_component_preview.rb index f078073b263..a0e252fba0b 100644 --- a/test/components/previews/events/rubygem_event/version/yank_forbidden_component_preview.rb +++ b/test/components/previews/events/rubygem_event/version/yank_forbidden_component_preview.rb @@ -1,21 +1,13 @@ class Events::RubygemEvent::Version::YankForbiddenComponentPreview < Lookbook::Preview - def default(rubygem: Rubygem.first!, # rubocop:disable Metrics/ParameterLists - reason: "Versions used for testing can't be yanked.", - number: "0.0.1", platform: "ruby", - version_gid: rubygem.versions.where(number:, platform:).first&.to_gid, - yanked_by: "Yanker", actor_gid: version_gid&.find&.yanker&.to_gid) - event = FactoryBot.build(:events_rubygem_event, rubygem:, tag: Events::RubygemEvent::VERSION_YANK_FORBIDDEN, additional: - { - number:, - platform:, - yanked_by:, + def default(rubygem: Rubygem.first!, **additional) + additional[:reason] ||= "Versions used for testing can't be yanked." + additional[:number] ||= "0.0.1" + additional[:platform] ||= "ruby" + additional[:version_gid] ||= rubygem.versions.where(number:, platform:).first&.to_gid + additional[:yanked_by] ||= "Yanker" + additional[:actor_gid] ||= version_gid.find.yanker.to_gid if additional[:version_gid] - version_gid:, - actor_gid:, - reason: - }) - render Events::RubygemEvent::Version::YankForbiddenComponent.new( - event: - ) + event = FactoryBot.build(:events_rubygem_event, rubygem:, tag: Events::RubygemEvent::VERSION_YANK_FORBIDDEN, additional:) + render Events::RubygemEvent::Version::YankForbiddenComponent.new(event:) end end diff --git a/test/components/previews/events/rubygem_event/version/yanked_component_preview.rb b/test/components/previews/events/rubygem_event/version/yanked_component_preview.rb index acbca8c9388..1a2fffd9c49 100644 --- a/test/components/previews/events/rubygem_event/version/yanked_component_preview.rb +++ b/test/components/previews/events/rubygem_event/version/yanked_component_preview.rb @@ -1,19 +1,12 @@ class Events::RubygemEvent::Version::YankedComponentPreview < Lookbook::Preview - def default(rubygem: Rubygem.first!, # rubocop:disable Metrics/ParameterLists - number: "0.0.1", platform: "ruby", - version_gid: rubygem.versions.where(number:, platform:).first&.to_gid, - yanked_by: "Yanker", actor_gid: version_gid&.find&.yanker&.to_gid) - event = FactoryBot.build(:events_rubygem_event, rubygem:, tag: Events::RubygemEvent::VERSION_YANKED, additional: - { - number:, - platform:, - yanked_by:, + def default(rubygem: Rubygem.first!, **additional) + additional[:number] ||= "0.0.1" + additional[:platform] ||= "ruby" + additional[:version_gid] ||= rubygem.versions.where(number:, platform:).first&.to_gid + additional[:yanked_by] ||= "Yanker" + additional[:actor_gid] ||= version_gid.find.yanker.to_gid if additional[:version_gid] - version_gid:, - actor_gid: - }) - render Events::RubygemEvent::Version::YankedComponent.new( - event: - ) + event = FactoryBot.build(:events_rubygem_event, rubygem:, tag: Events::RubygemEvent::VERSION_YANKED, additional:) + render Events::RubygemEvent::Version::YankedComponent.new(event:) end end