Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify exception handling. #132

Closed
Hc747 opened this issue Mar 18, 2020 · 0 comments · Fixed by #135
Closed

Unify exception handling. #132

Hc747 opened this issue Mar 18, 2020 · 0 comments · Fixed by #135
Assignees
@TheBlackParade
Labels
enhancement Enhancement to an existing feature

Comments

@Hc747
Copy link
Contributor

Hc747 commented Mar 18, 2020

Instead of adding a catch clause similar to:
catch(error => console.log(error));
to the end of each promise, I propose we should export a few generic (and re-useable) exception handlers so that changes to exception handling behaviour can be applied consistently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlackParade TheBlackParade

Labels
enhancement Enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding cleaner error handling for promises. runejs/server
2 participants
@Hc747 @TheBlackParade