Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Animations are cancelled after one tick #398

Closed
Jameskmonger opened this issue Jul 3, 2023 · 0 comments · Fixed by #402
Closed

[BUG] Animations are cancelled after one tick #398

Jameskmonger opened this issue Jul 3, 2023 · 0 comments · Fixed by #402
Labels
bug Something isn't working

Comments

@Jameskmonger
Copy link
Collaborator

Jameskmonger commented Jul 3, 2023

Describe the bug
Animations are cancelled after one tick of playing, they should continue to play to the end.

To Reproduce
Steps to reproduce the behavior:

  1. Run an emote such as "Jump for joy", you will notice it doesn't complete
  2. If you spam-click the animation button, the emote will complete

Expected behavior
The emote should run to its finish.

Additional context

I was able to fix this locally by going into player-sync-task.ts and changing the updateFlags.animation !== undefined checks to updateFlags.animation !== undefined && updateFlags.animation !== null.

The issue is that the "Reset animation" part is being called every tick, thus setting the animation back to -1.

Possibly we can just remove the undefined check entirely, and only check against null.

@Jameskmonger Jameskmonger added the bug Something isn't working label Jul 3, 2023
Jameskmonger added a commit to Jameskmonger/runejs-server that referenced this issue Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant