Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Logging out deletes NPCs #399

Closed
Jameskmonger opened this issue Jul 3, 2023 · 0 comments · Fixed by #413
Closed

[BUG] Logging out deletes NPCs #399

Jameskmonger opened this issue Jul 3, 2023 · 0 comments · Fixed by #413
Labels
bug Something isn't working

Comments

@Jameskmonger
Copy link
Collaborator

Describe the bug
When you log out, all NPCs are removed from the game

To Reproduce
Steps to reproduce the behavior:

  1. Run the server, and two instances of the client
  2. Log into the game with both client instances
  3. You will see NPCs around lumby
  4. Log out on one of the clients
  5. The other client will see all NPCs be deleted. They don't come back

Expected behavior
Only the player logging out should be removed from the world.

Screenshots
image

Additional context
Will try to investigate further and see if I can add some insight
@Jameskmonger Jameskmonger added the bug Something isn't working label Jul 3, 2023
Jameskmonger added a commit that referenced this issue Jul 17, 2023
@Jameskmonger
fix: check global instance correctly
0095a4f 
global instance now has an ID so we need to check against it rather than checking for `null`

fixes #399
@Jameskmonger Jameskmonger mentioned this issue Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check global instance correctly runejs/server
1 participant
@Jameskmonger