Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banking fixes #354

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Banking fixes #354

merged 3 commits into from
Oct 6, 2021

Conversation

RedSparr0w
Copy link
Contributor

Fix withdrawing non stackable items as stacks (closes #353)

Fix not being able to withdraw more noted items than you have space left in inventory.
Some (maybe all) noted items were not being detected as being stackable

Fix withdrawing non stackable items as stacks
Fix not being able to withdraw more noted items than you have space left in inventory.
Copy link
Collaborator

@SchauweM SchauweM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! Just added 2 small notes which have more to do with readability for others then with the actual code (which is awesome!)

src/plugins/objects/bank/bank.plugin.ts Outdated Show resolved Hide resolved
src/plugins/objects/bank/bank.plugin.ts Outdated Show resolved Hide resolved
@SchauweM SchauweM added bug Something isn't working plugins Updates involving content plugins labels Oct 6, 2021
@RedSparr0w
Copy link
Contributor Author

👍 Should all be good now 🤞

@SchauweM SchauweM merged commit 074374a into runejs:develop Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugins Updates involving content plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Withdrawing stacked non stackables from bank
2 participants