Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown #42

Open
mantou132 opened this issue Jul 6, 2019 · 8 comments
Open

Support markdown #42

mantou132 opened this issue Jul 6, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@mantou132
Copy link

Screen Shot 2019-07-06 at 3 40 15 PM

@justinfagnani
Copy link
Collaborator

@mantou132 can you describe the issue here?

@mantou132
Copy link
Author

hope the lit-html snippet in markdown can also be highlighted.

@runem runem transferred this issue from runem/vscode-lit-plugin Aug 12, 2019
@runem runem added the enhancement New feature or request label Sep 22, 2019
@runem runem changed the title support mackdown Support markdown Sep 22, 2019
@LarsDenBakker
Copy link

This would be a great feature to have, when working with storybook a lot of code is written in markdown files.

@daKmoR
Copy link

daKmoR commented Feb 3, 2020

here is a use case

Screenshot 2020-02-03 at 21 44 06

would be awesome if that is highlighted 👍

do you have some pointer on where to start looking to get this supported? e.g. we can contribute but we probably need a little help to get started 🤗

@runem
Copy link
Owner

runem commented Mar 6, 2020

First of all, sorry for the long response time in this issue :-)

I agree that this would be a nice feature to have!

We would have to upstream this issue to https://github.com/microsoft/typescript-lit-html-plugin (which includes grammars for syntax highlighting) because lit-plugin depends on that library.

And sorry, I can't help much with a PR, because I'm not very experienced in writing grammars for VS Code.

@daKmoR
Copy link

daKmoR commented Mar 6, 2020

opened an issue 🤗let's hope it's not a tough feature 🙏

microsoft/typescript-lit-html-plugin#34

@daKmoR
Copy link

daKmoR commented Mar 20, 2020

ok it was yet in another repo 😅

new issue: mjbvz/vscode-lit-html#76

but there seems to be interest 💪

@runem
Copy link
Owner

runem commented Mar 20, 2020

I'm sorry, my bad ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants