some bindgen wrapper.c objects fail with htslib 1.11 upgrade (#275)

* Fix for OSX compilation (without MUSL for now since it fails on wrapper.c).

Author: brainstorm

.github/workflows/rust.yml

@@ -92,19 +92,74 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
           use-cross: true
-          command: build
+          command: test
           args: --release --target x86_64-unknown-linux-musl --no-default-features
 
       - name: Test musl build with all features
         uses: actions-rs/cargo@v1
         with:
           use-cross: true 
-          command: build
+          command: test
           args: --release --target x86_64-unknown-linux-musl --all-features --verbose
 
       - name: Test musl build with all features and debug symbols (non --release)
         uses: actions-rs/cargo@v1
         with:
           use-cross: true 
-          command: build
+          command: test
           args: --target x86_64-unknown-linux-musl --all-features --verbose
+
+  Testing-OSX:
+    needs: Formatting
+    runs-on: macOS-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/[email protected]
+        with:
+          submodules: true
+      
+      - name: Install htslib dependencies
+        run: brew install bzip2 zlib xz curl-openssl
+
+      # Test for Intel OSX
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          target: x86_64-apple-darwin
+          override: true
+
+      - name: Test build without default features for the default x86_64 OSX target
+        uses: actions-rs/[email protected]
+        with:
+          use-cross: false  # cross is not supported on GHA OSX runner, see: https://github.community/t/why-is-docker-not-installed-on-macos/17017
+          command: test
+          args: --release --all-features --verbose
+
+      # Test MUSL builds on OSX
+      #
+      # - uses: actions-rs/toolchain@v1
+      #   with:
+      #     toolchain: stable
+      #     target: x86_64-unknown-linux-musl
+      #     override: true
+
+      # - name: Install OSX musl-cross
+      #   run: brew install FiloSottile/musl-cross/musl-cross
+
+      # # https://github.com/FiloSottile/homebrew-musl-cross/issues/16
+      # - name: Provide musl-gcc symlink for the right musl arch
+      #   run: ln -sf /usr/local/opt/musl-cross/libexec/bin/x86_64-linux-musl-gcc /usr/local/bin/musl-gcc
+
+      # - name: Test musl build without default features
+      #   uses: actions-rs/cargo@v1
+      #   with:
+      #     use-cross: false  # cross is not supported on GHA OSX runner, see: https://github.community/t/why-is-docker-not-installed-on-macos/17017
+      #     command: test
+      #     args: --release --target x86_64-unknown-linux-musl --no-default-features
+
+      # - name: Test musl build with all features and debug symbols (non --release) on OSX
+      #   uses: actions-rs/[email protected]
+      #   with:
+      #     use-cross: false
+      #     command: test
+      #     args: --target x86_64-unknown-linux-musl --all-features --verbose

hts-sys/build.rs

@@ -83,9 +83,9 @@ fn main() {
     let want_static = cfg!(feature = "static") || env::var("HTS_STATIC").is_ok();
 
     if want_static {
-        cfg.warnings(true).static_flag(true).pic(true);
+        cfg.warnings(false).static_flag(true).pic(true);
     } else {
-        cfg.warnings(true).static_flag(false).pic(true); 
+        cfg.warnings(false).static_flag(false).pic(true);
     }
 
     if let Ok(z_inc) = env::var("DEP_Z_INCLUDE") {
@@ -252,4 +252,4 @@ fn main() {
     // Note: config.h is a function of the cargo features. Any feature change will 
     // cause build.rs to re-run, so don't re-run on that change.
     //println!("cargo:rerun-if-changed=htslib/config.h");
-}
+}