Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers/krate/delete: Adjust HTTP status code #10169

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 9, 2024

DELETE endpoints are supposed to return "204 No Content" upon successful deletion, unless the response contains an entity, which is not the case here.

see https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE#successfully_deleting_a_resource

`DELETE` endpoints are supposed to return "204 No Content" upon successful deletion, unless the response contains an entity, which is not the case here.

see https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE#successfully_deleting_a_resource
@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (7541baf) to head (2a3755a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10169   +/-   ##
=======================================
  Coverage   89.57%   89.58%           
=======================================
  Files         295      295           
  Lines       31690    31694    +4     
=======================================
+ Hits        28386    28392    +6     
+ Misses       3304     3302    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit b883ebb into rust-lang:main Dec 10, 2024
10 checks passed
@Turbo87 Turbo87 deleted the delete-status branch December 10, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant