Skip to content

Docs.rs is generating external dependency links #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nemo157 opened this issue Feb 23, 2022 · 1 comment · Fixed by #1473
Closed

Docs.rs is generating external dependency links #1686

Nemo157 opened this issue Feb 23, 2022 · 1 comment · Fixed by #1473
Labels
A-backend Area: Webserver backend A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@Nemo157
Copy link
Member

Nemo157 commented Feb 23, 2022

The source link for https://docs.rs/rand/latest/rand/trait.SeedableRng.html#method.seed_from_u64 links to https://rust-random.github.io/rand/src/rand_core/lib.rs.html#306 instead of https://docs.rs/rand_core/0.6.3/src/rand_core/lib.rs.html#306-335; and https://docs.rs/rand_mt/4.1.1/rand_mt/struct.Mt19937GenRand32.html#impl-RngCore links to https://rust-random.github.io/rand/rand_core/trait.RngCore.html instead of https://docs.rs/rand_core/0.6.3/rand_core/trait.RngCore.html.

IIRC there was some plan on changing how --extern-html-root-url worked when a crate specified its own html_root_url, but there was going to be a flag for docs.rs to keep the previous override behavior.

@Nemo157 Nemo157 added C-bug Category: This is a bug A-builds Area: Building the documentation for a crate A-backend Area: Webserver backend labels Feb 23, 2022
@jyn514
Copy link
Member

jyn514 commented Feb 23, 2022

This is #1473, I haven't had time to work on it. Happy for someone else to fix it up - I think you may just need to rerun the ci job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend Area: Webserver backend A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants