Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: Can we use proper libc typedefs in stat definition? #3285

Open
danielocfb opened this issue Jun 27, 2023 · 1 comment · May be fixed by #3286
Open

android: Can we use proper libc typedefs in stat definition? #3285

danielocfb opened this issue Jun 27, 2023 · 1 comment · May be fixed by #3286
Labels
C-bug Category: bug
Milestone
1.0

Comments

@danielocfb
Copy link

danielocfb commented Jun 27, 2023 •
edited
Loading

If we look at the stat type's definition for different platforms, we see:

st_dev: dev_t
st_ino: ino_t
[...]

But for arm-linux-androideabi we stop using libc typedefs and instead have:

st_dev: c_ulonglong
st_mode: c_uint
[...]
st_ino: c_ulonglong

Is there a (good) reason for this divergence? If I look at ino_t it's actually defined to be a c_ulong, not c_ulonglong, so that will lead to mismatches all over the place when the typedefs are used. Is this mandated somewhere, a bug in the platform definition that we need to support? This is a nightmare to support in user code.
@danielocfb danielocfb added the C-bug Category: bug label Jun 27, 2023
devnexen added a commit to devnexen/libc that referenced this issue Jun 28, 2023
@devnexen
android 32 bits fix stat struct proposal.
57bfcd8 
close rust-lang#3285
@devnexen devnexen linked a pull request Jun 28, 2023 that will close this issue
Open
bors added a commit that referenced this issue Jan 8, 2024
@bors
Auto merge of #3286 - devnexen:stat_android_fix, r=JohnTitor
3fac855 
android 32 bits fix stat struct proposal.

close #3285
JohnTitor pushed a commit to devnexen/libc that referenced this issue Jan 31, 2024
@devnexen @JohnTitor
android 32 bits fix stat struct proposal.
8126c61 
close rust-lang#3285
tgross35 pushed a commit to devnexen/libc that referenced this issue Aug 13, 2024
@devnexen @tgross35
android 32 bits fix stat struct proposal.
4a1afe6 
close rust-lang#3285
devnexen added a commit to devnexen/libc that referenced this issue Aug 16, 2024
@devnexen
android 32 bits fix stat struct proposal.
94088a8 
close rust-lang#3285
@tgross35 tgross35 added this to the 1.0 milestone Aug 29, 2024
@maurer
Copy link

maurer commented Nov 21, 2024

Please reference the bionic definition when updating Android libc structures - this is the canonical definition.

Beyond the canonicity, the reason this structure is different is the same reason it's different in e.g. musl - the kernel actually has a differently shaped structure, fills out fewer bits of the inode, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

android 32 bits fix stat struct proposal. devnexen/libc
3 participants
@maurer @tgross35 @danielocfb