Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the same sched.h constants for musl as gnu #3534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alyssais
Copy link

I don't understand why these constants from Linux headers aren't just defined in linux_like/mod.rs. Surely they'd be the same for every libc?

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 11, 2024

📌 Commit 2670fb1 has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jan 11, 2024
Provide the same sched.h constants for musl as gnu

I don't understand why these constants from Linux headers aren't just defined in linux_like/mod.rs.  Surely they'd be the same for every libc?
@bors
Copy link
Contributor

bors commented Jan 11, 2024

⌛ Testing commit 2670fb1 with merge 0cad2c2...

@bors
Copy link
Contributor

bors commented Jan 11, 2024

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

CI fails: https://github.com/rust-lang/libc/actions/runs/7487138095/job/20379076829
It'd also be great if you could rebase onto main to trigger full CI.

@tgross35
Copy link
Contributor

@alyssais are you able to update this to get it over the line? If you need help figuring out the CI, let me know.

@tgross35
Copy link
Contributor

@alyssais ping, are you able to update this?

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-gnu O-linux O-musl O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants