Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to automatically apply fixes suggested by rustc to crate DEL2 #13683

Open
magnetophon opened this issue Nov 14, 2024 · 3 comments
Open
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@magnetophon
Copy link

Summary

Clippy suggested to fix a lot of warnings, but instead gave me this output and told me to pass it on to here.

https://gist.github.com/magnetophon/7f82c5be3ce2cfc7c874cff30a5f9a83

Reproducer

I tried this code:

magnetophon/DEL2@075fb6b

Clippy suggested to fix some warnings, but instead generated the above output.

Version

rustc 1.84.0-nightly (b8c8287a2 2024-11-03)
binary: rustc
commit-hash: b8c8287a229cd79604aa84c25e1235fc78cd5f2e
commit-date: 2024-11-03
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.3

Additional Labels

No response

@magnetophon magnetophon added the C-bug Category: Clippy is not doing the correct thing label Nov 14, 2024
magnetophon added a commit to magnetophon/DEL2 that referenced this issue Nov 14, 2024
try to get clippy to fix use_self

see: rust-lang/rust-clippy#13683
@magnetophon
Copy link
Author

FWIW: Clippy was able to do some automatic fixes it after I made some structs pub: magnetophon/DEL2@b5ec2dc

After doing the fixes: magnetophon/DEL2@c9b69be, I oticed it complained about a few of those same structs being pub, so i undid part of that change: magnetophon/DEL2@375a7c6.

I'm pretty new to rust, so this could very well just be an error on my part,
If it is, sorry for the noise!

@blyxyas
Copy link
Member

blyxyas commented Nov 27, 2024

Hi @magnetophon, sorry for the delay.
What the commit you linked did enabled nursery lints, the nursery category is a special one. These lints are a WIP, have too many false positives / false negatives, or have a known bug intense enough that merit their change of category.

We're working in stripping these down in the future :)

@magnetophon
Copy link
Author

Thanks for clearing that up.
Feel free to close this issue if you think it's unneeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Development

No branches or pull requests

2 participants