if_assert

[Rudxain]

What it does

It should deny or warn when a predicate is checked by both an assert (or any similar built-in macro) and any conditional control-flow construct, in any order

Advantage

• It removes a redundant check that's certainly a bug
• Less confusion for readers
• No change in code-gen, as the optimizer could catch the dupe and eliminate it

Drawbacks

• False negatives because of custom macros
• Cannot be auto-fixed, because intent isn't clear (wrong?)

Example

fn f<T: std::fmt::Debug + PartialEq>(a: T, b: T) {
    if a == b {
        assert_eq!(a, b);
        // do something
    }
}

fn g<T: std::fmt::Debug + PartialEq>(a: T, b: T) {
    assert_eq!(a, b);
    if a == b {
        // do something
    }
}

Could be written as:

fn f<T: std::fmt::Debug + PartialEq>(a: T, b: T) {
    if a == b {
        // do something
    }
}

fn g<T: std::fmt::Debug + PartialEq>(a: T, b: T) {
    assert_eq!(a, b);
    // do something
}