Skip to content

Commit 230dda4

Browse files
authored
Merge pull request #876 from apiraino/remove-wg-prio
2 parents 4d9dba6 + cc3e6ea commit 230dda4

File tree

5 files changed

+17
-26
lines changed

5 files changed

+17
-26
lines changed

src/compiler/prioritization.md

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ Examples of things we typically judge to be “critical” bugs:
4949
- If a regression has been in stable for a release or two (either because we are still awaiting a
5050
fix, or because the bug had laid dormant i.e. undetected), we typically lower the priority as
5151
well, because by that time, if the users have not raised a ruckus about the regression, that
52-
is a sign that it is inherently not a critical issue.
53-
- e.g. [an issue that would have been `P-critical` but ended up being
54-
`P-high`][critical_downgrade_example]
52+
is a sign that it is inherently not a critical issue
5553
- Regressions where code still compiles but does something different than it used to do (dynamic
5654
semantics have changed)
5755
- Mitigating conditions that may lower priority:
@@ -76,8 +74,6 @@ Examples of things we typically judge to be “critical” bugs:
7674
A `P-critical` issue will receive the most attention. It must be assigned one or several people as
7775
soon as possible, and the rest of the team should do their best to help them out if/when applicable.
7876

79-
[critical_downgrade_example]: https://rust-lang.zulipchat.com/#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/pre-meeting.20triage.202020-04-09.20.2354818
80-
8177
## P-high
8278
`P-high` issues are issues that need attention from the compiler team, but not to the point that
8379
they need to be discussed at every meeting. They can be `P-critical` issues that have a mitigating
@@ -122,14 +118,13 @@ First, ensure that relevant issues are labelled as `T-compiler`..
122118
- [Issues classified with priority `P-high`](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-high+-label%3AT-compiler+-label%3AT-cargo+-label%3AT-core+-label%3AT-doc+-label%3AT-infra+-label%3AT-lang+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AA-rustdoc+-label%3AA-rustdoc-ui)
123119

124120
..and that prioritization has been completed. Regressions labeled with `I-prioritize` are signaling
125-
that a priority assessment is waiting. When this label is added to an issue, the `triagebot` creates
126-
automatically a notification for @*WG-prioritization* members on [the
127-
`#t-compiler/prioritization/alerts` Zulip channel][prio_channel].
121+
that a priority assessment is waiting. When this label is added to an issue, the `triagebot` sends a
122+
notification to the [`#t-compiler/prioritization/alerts`][prio_channel] Zulip channel.
128123

129-
[prio_channel]: https://rust-lang.zulipchat.com/#narrow/stream/245100-t-compiler.2Fwg-prioritization.2Falerts
124+
[prio_channel]: https://rust-lang.zulipchat.com/#narrow/channel/245100-t-compiler.2Fprioritization.2Falerts
130125

131126
To assign a priority, replace the `I-prioritize` label with one of `P-critical`, `P-high`,
132-
`P-medium` or `P-low` and adding a succinct comment to link the Zulip discussion where the issue
127+
`P-medium` or `P-low` and add a succinct comment to link the Zulip discussion where the issue
133128
prioritization occurred, example of a template for the comment:
134129

135130
> Assigning priority (discussion on [Zulip](#)).
@@ -138,12 +133,11 @@ prioritization occurred, example of a template for the comment:
138133
139134
Tip: use [Github Saved Replies](https://docs.github.com/get-started/writing-on-github/working-with-saved-replies) to create a template comment.
140135

141-
Ideally, all [`T-compiler` issues with a `I-prioritize` label][issues_needing_prio] to have a
136+
Ideally, all [`T-compiler` issues with a `I-prioritize` label][issues_needing_prio] should have a
142137
priority assigned, or strive to reach this goal: sometimes different factors are blocking issues
143-
from being assigned a priority label, either because the report or the context is unclear or
144-
because cannot be reproduced and an MCVE would help. Don't hesitate to ask for clarifications to
145-
the issue reporter or ping the `ICEbreaker` team when an ICE ("Internal Compiler Errors") needs a
146-
reduction (add a comment on the issue with `@rustbot ping icebreakers-cleanup-crew`)
138+
from being assigned a priority label, either because the report or the context is unclear or because
139+
cannot be reproduced and an MCVE would help. Don't hesitate to ask for clarifications to the issue
140+
reporter or to other contributors.
147141

148142
Review [stable][stable_regressions], [beta][beta_regressions] and [nightly][nightly_regressions] and
149143
try to ensure they are assigned when possikle.
@@ -159,19 +153,16 @@ close the issue.
159153

160154
[mcp_fcp]: https://github.com/rust-lang/compiler-team/issues?q=is%3Aissue+is%3Aopen+label%3Amajor-change+label%3Afinal-comment-period
161155

162-
Finally, the meeting agenda can be generated. Clone and build [`triagebot`][triagebot] and set the
163-
`GITHUB_TOKEN` environment variable with a GitHub API token.
156+
Finally, the meeting agenda can be generated. Clone and build [`triagebot`][triagebot] and run:
164157

165158
[triagebot]: https://github.com/rust-lang/triagebot
166159

167-
Then generate the agenda with:
168-
169160
```
170161
$ cargo run --bin prioritization-agenda
171162
```
172163

173164
Copy the content into a new HackMD in the "Rust Lang Compiler Team" space. Copy the most recent
174-
[performance triage logs][perf_triage_log] and remove anything that won't display well in Zulip
165+
[performance triage logs][perf_triage_log] (doing a bit of cleanup, removing anything that won't display well in Zulip)
175166

176167
[perf_triage_log]: https://github.com/rust-lang/rustc-perf/tree/master/triage#triage-logs
177168

src/release/issue-triaging.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,14 @@ There are many different labels that can be applied to issues.
113113
- `regression-from-stable-to-{beta,nightly}`: Something that regressed from the a stable release to beta or nightly channel.
114114
- [`I-*`]: Different labels about the nature[^2] of an issue.
115115
- `I-ICE`: Internal compiler error.
116-
- `I-prioritize`: Indicates that the issue should be additionally triaged by the [T-compiler prioritization working group (WG-priority)](../compiler/prioritization.md) to assign a priority `P-*` if applicable to indicate the urgency.
116+
- `I-prioritize`: Indicates that the issue should be additionally triaged by [T-compiler/ops](../compiler/prioritization.md) to assign a priority `P-*` if applicable to indicate the urgency.
117117
- `I-heavy`: Heavy code (binary size).
118118
- `I-slow`: Slow run-time performance.
119119
- `I-hang`: The compilation fails to complete after a long time.
120120
- `I-crash`: The compiler or generated code crashes but does not manifest as an ICE, e.g. SIGSEGV or access violations.
121121
- `I-unsound`: Library, compiler, type system or language unsoundness.
122122
- `I-compilemem`: Excessive memory usage during compilation.
123-
- `I-compiletime`: Slow compilation time.
123+
- `I-compiletime`: Slow compilation time.
124124
- `I-{team}-nominated`: Issue is nominated for discussion by `{team}`. E.g. `I-compiler-nominated`.
125125
- `I-lang-easy-decision`: The decision needed by T-lang is conjectured (by the person applying the label) to be easy or perfunctory. Note that this label does not imply `I-lang-nominated`; the nomination label should be applied simultaneously if the person apply the label wants to nominate the issue for T-lang discussion.
126126
- [`P-*`]: Priority labels. Applied using the [compiler prioritization procedure](../compiler/prioritization.md).

src/triagebot/labeling.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Formally the grammar is:
5656

5757
### Permissions
5858

59-
All labels can be assigned by rust-lang organization team members (and wg-triage, wg-prioritization, and wg-async).
59+
All labels can be assigned by rust-lang organization team members (and wg-triage, wg-async).
6060
Users not on a team can only assign labels that are explicitly authorized in `triagebot.toml`.
6161
It is encouraged for maintainers to allow the majority of labels to be applied by anyone.
6262
An example of one that would be restricted is `beta-accepted`, since accepting a backport to beta is usually only done by a team member.

src/triagebot/pinging.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The message will include a `cc` line that `@`-mentions all members of the team.
99

1010
## Usage
1111

12-
On repositories with a ping group configured, any Rust team member (and wg-triage, wg-prioritization, and wg-async) can write a GitHub comment such as:
12+
On repositories with a ping group configured, any Rust team member (and wg-triage, wg-async) can write a GitHub comment such as:
1313

1414
```text
1515
@rustbot ping windows
@@ -21,7 +21,7 @@ which would cause triagebot to post a comment notifying the members of the `wind
2121

2222
To be pinged, teams have to be created in the [Rust team repository](https://github.com/rust-lang/team).
2323
Frequently those teams will be marked as `marker-team`, meaning that they do not appear on the website.
24-
The [Icebreakers LLVM team](https://github.com/rust-lang/team/blob/master/teams/icebreakers-llvm.toml#L2) is an example.
24+
The [WASM team](https://github.com/rust-lang/team/blob/master/teams/wasm.toml#L2) is an example.
2525

2626
Additionally, the team needs to be configured in the repository's `triagebot.toml` file.
2727

src/triagebot/transfer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ implements diagnostic reports.
2121

2222
**WARNING:** Transferring is a partially destructive command. For example, labels and milestones that don't exist in the target repository will be removed from the issue.
2323

24-
The transfer command is limited to team members of the rust-lang org, as well as members of `wg-triage`, `wg-prioritization`, and `wg-async`, and transfers can only happen to repositories in the rust-lang org. Also, the destination repository must have triagebot enabled on it.
24+
The transfer command is limited to team members of the rust-lang org, as well as members of `wg-triage` and `wg-async`. Transfers can only happen to repositories in the rust-lang org. Also, the destination repository must have triagebot enabled on it.
2525

2626
## Configuration
2727

0 commit comments

Comments
 (0)