Skip to content

Commit 7fb5bc5

Browse files
codegen: modernize frame-pointer-cli-control.rs
Update this time-traveler on the changes in compiletest and target specs that they missed over the pass ~3 years by being caught in a time rift. The aarch64-apple rev splits into itself and aarch64-apple-on, because rustc obtained support for non-leaf frame-pointers ever since 9b67cba implemented them and used them in aarch64-apple-darwin's spec. Note that the aarch64-apple-off revision fails, despite modernization. This is because 9b67cba also changed the behavior of rustc to defer to the spec over the command-line interface.
1 parent 71ed34c commit 7fb5bc5

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

tests/codegen/frame-pointer-cli-control.rs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
// compile-flags: --crate-type=rlib -Copt-level=0
2-
// revisions: force-on aarch64-apple aarch64-apple-off
3-
// [force-on] compile-flags: -Cforce-frame-pointers=on
4-
// [aarch64-apple] needs-llvm-components: aarch64
5-
// [aarch64-apple] compile-flags: --target=aarch64-apple-darwin
6-
// [aarch64-apple-off] needs-llvm-components: aarch64
7-
// [aarch64-apple-off] compile-flags: --target=aarch64-apple-darwin -Cforce-frame-pointers=off
1+
//@ compile-flags: --crate-type=rlib -Copt-level=0
2+
//@ revisions: force-on aarch64-apple aarch64-apple-on aarch64-apple-off
3+
//@ [force-on] compile-flags: -Cforce-frame-pointers=on
4+
//@ [aarch64-apple] needs-llvm-components: aarch64
5+
//@ [aarch64-apple] compile-flags: --target=aarch64-apple-darwin
6+
//@ [aarch64-apple-on] needs-llvm-components: aarch64
7+
//@ [aarch64-apple-on] compile-flags: --target=aarch64-apple-darwin -Cforce-frame-pointers=on
8+
//@ [aarch64-apple-off] needs-llvm-components: aarch64
9+
//@ [aarch64-apple-off] compile-flags: --target=aarch64-apple-darwin -Cforce-frame-pointers=off
810
/*
911
Tests that the frame pointers can be controlled by the CLI. We find aarch64-apple-darwin useful
1012
because of its icy-clear policy regarding frame pointers (software SHALL be compiled with them),
@@ -30,6 +32,7 @@ pub fn peach(x: u32) -> u32 {
3032

3133
// CHECK: attributes [[PEACH_ATTRS]] = {
3234
// force-on-SAME: {{.*}}"frame-pointer"="all"
33-
// aarch64-apple-SAME: {{.*}}"frame-pointer"="all"
35+
// aarch64-apple-SAME: {{.*}}"frame-pointer"="non-leaf"
36+
// aarch64-apple-on-SAME: {{.*}}"frame-pointer"="all"
3437
// aarch64-apple-off-NOT: {{.*}}"frame-pointer"{{.*}}
3538
// CHECK-SAME: }

0 commit comments

Comments
 (0)