std: complete unifying the TLS destructor list implementations

Author: joboet

library/std/src/sys/hermit/mod.rs

@@ -40,7 +40,7 @@ pub mod pipe;
 pub mod process;
 pub mod stdio;
 pub mod thread;
-pub mod thread_local_dtor;
+pub mod thread_local_guard;
 #[path = "../unsupported/thread_local_key.rs"]
 pub mod thread_local_key;
 pub mod time;
@@ -115,7 +115,7 @@ pub unsafe extern "C" fn runtime_entry(
     argv: *const *const c_char,
     env: *const *const c_char,
 ) -> ! {
-    use crate::sys::hermit::thread_local_dtor::run_dtors;
+    use crate::sys::common::thread_local::run_dtors;
     extern "C" {
         fn main(argc: isize, argv: *const *const c_char) -> i32;
     }
@@ -125,7 +125,7 @@ pub unsafe extern "C" fn runtime_entry(
 
     let result = main(argc as isize, argv);
 
-    run_dtors();
+    run_dtors(crate::ptr::null_mut());
     abi::exit(result);
 }
 

library/std/src/sys/hermit/thread.rs

@@ -5,8 +5,8 @@ use crate::io;
 use crate::mem;
 use crate::num::NonZeroUsize;
 use crate::ptr;
+use crate::sys::common::thread_local::run_dtors;
 use crate::sys::hermit::abi;
-use crate::sys::hermit::thread_local_dtor::run_dtors;
 use crate::time::Duration;
 
 pub type Tid = abi::Tid;
@@ -50,7 +50,7 @@ impl Thread {
                 Box::from_raw(ptr::from_exposed_addr::<Box<dyn FnOnce()>>(main).cast_mut())();
 
                 // run all destructors
-                run_dtors();
+                run_dtors(ptr::null_mut());
             }
         }
     }

library/std/src/sys/hermit/thread_local_dtor.rs

@@ -1,27 +1,6 @@
 #![cfg(target_thread_local)]
 #![unstable(feature = "thread_local_internals", issue = "none")]
 
-// Simplify dtor registration by using a list of destructors.
-// The this solution works like the implementation of macOS and
-// doesn't additional OS support
-
-use crate::mem;
-
-#[thread_local]
-static mut DTORS: Vec<(*mut u8, unsafe extern "C" fn(*mut u8))> = Vec::new();
-
-pub unsafe fn register_dtor(t: *mut u8, dtor: unsafe extern "C" fn(*mut u8)) {
-    let list = &mut DTORS;
-    list.push((t, dtor));
-}
-
-// every thread call this function to run through all possible destructors
-pub unsafe fn run_dtors() {
-    let mut list = mem::take(&mut DTORS);
-    while !list.is_empty() {
-        for (ptr, dtor) in list {
-            dtor(ptr);
-        }
-        list = mem::take(&mut DTORS);
-    }
+pub fn activate() {
+    // run_dtors is always executed by the threading support.
 }

library/std/src/sys/itron/thread.rs

@@ -11,9 +11,9 @@ use crate::{
     ffi::CStr,
     hint, io,
     mem::ManuallyDrop,
-    ptr::NonNull,
+    ptr::{self, NonNull},
     sync::atomic::{AtomicUsize, Ordering},
-    sys::thread_local_dtor::run_dtors,
+    sys::common::thread_local::run_dtors,
     time::Duration,
 };
 
@@ -115,7 +115,7 @@ impl Thread {
 
             // Run TLS destructors now because they are not
             // called automatically for terminated tasks.
-            unsafe { run_dtors() };
+            unsafe { run_dtors(ptr::null_mut()) };
 
             let old_lifecycle = inner
                 .lifecycle

library/std/src/sys/solid/mod.rs

@@ -41,7 +41,7 @@ pub mod process;
 pub mod stdio;
 pub use self::itron::thread;
 pub mod memchr;
-pub mod thread_local_dtor;
+pub mod thread_local_guard;
 pub mod thread_local_key;
 pub use self::itron::thread_parking;
 pub mod time;

library/std/src/sys/solid/thread_local_dtor.rs

@@ -0,0 +1,21 @@
+//! Ensures that thread-local destructors are run on thread exit.
+
+#![cfg(target_thread_local)]
+#![unstable(feature = "thread_local_internals", issue = "none")]
+
+use super::{abi, itron::task};
+use crate::cell::Cell;
+use crate::sys::common::thread_local::run_dtors;
+
+#[thread_local]
+static REGISTERED: Cell<bool> = Cell::new(false);
+
+pub fn activate() {
+    if !REGISTERED.get() {
+        let tid = task::current_task_id_aborting();
+        // Register `tls_dtor` to make sure the TLS destructors are called
+        // for tasks created by other means than `std::thread`
+        unsafe { abi::SOLID_TLS_AddDestructor(tid as i32, run_dtors) };
+        REGISTERED.set(true);
+    }
+}