Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track whether a non-coherence TypingMode has been used to reuse cache entries #133497

Open
lcnr opened this issue Nov 26, 2024 · 1 comment
Open

track whether a non-coherence TypingMode has been used to reuse cache entries #133497

lcnr opened this issue Nov 26, 2024 · 1 comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented Nov 26, 2024

see the WIP branch https://github.com/lcnr/rust/tree/typing-mode-is-coherence.

It is now fairly straightforward to track whether evaluation relied on the exact typing mode. finishing this work should result in a reasonable perf improvement
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 26, 2024
@lcnr
Copy link
Contributor Author

lcnr commented Nov 26, 2024

See the perf results in #133242 (comment) which accidentally stopped tracking the TypingMode entirely for a rough estimate of the potential impact

@jieyouxu jieyouxu added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-types Relevant to the types team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 26, 2024
@compiler-errors compiler-errors added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@compiler-errors @lcnr @jieyouxu @rustbot