Skip to content

Add IRC's !union union as a test #43553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Havvy opened this issue Jul 30, 2017 · 4 comments
Closed

Add IRC's !union union as a test #43553

Havvy opened this issue Jul 30, 2017 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Havvy
Copy link
Contributor

Havvy commented Jul 30, 2017

The factoid union union has playbot run this code: #![allow(bad_style)] union union<'union> { union: &'union union<'union>, }. It should be added as a test in src/test/run-pass/wierd-exprs.rs.
@Havvy
Copy link
Contributor Author

Havvy commented Jul 30, 2017

Requesting tag for "E-Easy" and whatever the good first bug one is if it's not E-Easy.

@Mark-Simulacrum Mark-Simulacrum added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2017
@kennytm
Copy link
Member

kennytm commented Jul 30, 2017

I wonder if we will get similar tests for default and catch...

@arshiamufti
Copy link
Contributor

I'm going to work on this with @steveklabnik 🎉

@kennytm kennytm mentioned this issue Aug 9, 2017
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 11, 2017
@GuillaumeGomez
Rollup merge of rust-lang#43752 - arshiamufti:union-test, r=estebank
35947cf 
Add IRC's `!union union` as a test, addresses rust-lang#43553

This pull request adds a new test, `union` to `weird-exprs.rs`.
MaloJaffre added a commit to MaloJaffre/rust that referenced this issue Aug 11, 2017
@MaloJaffre
Rollup merge of rust-lang#43752 - arshiamufti:union-test, r=estebank
0ea8e0e 
Add IRC's `!union union` as a test, addresses rust-lang#43553

This pull request adds a new test, `union` to `weird-exprs.rs`.
@tamird
Copy link
Contributor

tamird commented Aug 19, 2017

Fixed in #43752. @steveklabnik @sfackler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kennytm @Havvy @tamird @Mark-Simulacrum @petrochenkov @arshiamufti