[CORE] added unreachable unwrap function to Option

[Cr0a3]

Hi,
In this PR i added a function to Option which throws an unreachable exception, if the internal value is None.

Would this have use cases?

Yes, I want a feature like that for a very long time.
It would make development of some of my codegen libs easier.

Best wishes,
Toni

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @workingjubilee (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[cyrgani]

See rust-lang/rfcs#3706 for a longer discussion of such a function and alternatives too.

[workingjubilee]

Please file an ACP.

[workingjubilee]

As unwrap_unchecked exists, which is equivalent to a match which uses unreachable_unchecked on the None branch, I really don't think this is a good function to add as it just adds more confusion about what can be done with an option. You can use an extension trait to add your particular personal functions that you want.

If you didn't know about those functions before I told you about them, that's my point: the API is already too big for it to be easily learnable.

[Cr0a3]

As unwrap_unchecked exists, which is equivalent to a match which uses unreachable_unchecked on the None branch, I really don't think this is a good function to add as it just adds more confusion about what can be done with an option. You can use an extension trait to add your particular personal functions that you want.

If you didn't know about those functions before I told you about them, that's my point: the API is already too big for it to be easily learnable.

Ok, then I am going to close this pr