Skip to content

edition 2024 and remove #![feature(let_chains)] #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #140722
est31 opened this issue May 6, 2025 · 3 comments · Fixed by #663
Closed
Tracked by #140722

edition 2024 and remove #![feature(let_chains)] #662

est31 opened this issue May 6, 2025 · 3 comments · Fixed by #663

Comments

@est31
Copy link
Member

est31 commented May 6, 2025

Hi, I would like to properly stabilize the let_chains feature. For users on edition 2024, this has already happened in rust-lang/rust#132833, but the feature is still available behind a feature gate on older editions. Eventually I want to remove that feature gate, removing the ability to use let chains on editions < 2024. But this crate is currently using edition 2018.

How hard would it be to update the edition from 2018 to 2024 and remove the #![feature(let_chains)]?

cc rust-lang/rust#140722

@antoyo
Copy link
Contributor

antoyo commented May 6, 2025

I believe it should not be that hard to update to edition 2024.

@GuillaumeGomez
Copy link
Member

Gonna do it, like that it's already done and we can remove the feature when stabilized.

@est31
Copy link
Member Author

est31 commented May 9, 2025

Thanks @GuillaumeGomez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants