-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ndarray to 0.15.0 #156
Conversation
replacing the operator with |
the construction of the sparse matrix fails though in the line above and I'm not yet sure why |
the new constructor assumes ordered indices, this solves it: // create CSR matrix from data, indptr and indices
let mat = CsMatBase::new_from_unsorted((n_points, n_points), indptr, indices, data).unwrap();
let mut mat = sprs::binop::csmat_binop(mat.view(), mat.transpose_view().to_other_storage().view(), |x, y| x.add(*y)); |
It seems there are some strange type inference going on when using // create CSR matrix from data, indptr and indices
let mat = CsMat::<F>::new_from_unsorted((n_points, n_points), indptr, indices, data).unwrap();
let transpose = mat.transpose_view().to_other_storage();
sprs::binop::csmat_binop(mat.view(), transpose.view(), |_, _| F::one()) This does the same as we do behind the scene. I have assumed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
the CI pipeline somehow failed to run here as well, I checked manually .. |
Addresses #124.
Having issues with new version of
sprs
. The compile error most likely has something to do with sparsemat/sprs#278 and was introduced by sparsemat/sprs#290.