-
-
Notifications
You must be signed in to change notification settings - Fork 170
CI workflow changes #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree that a perpetually failing CI is not useful. However, we still want to have the CI test the library as much as possible. Have it merely running
Therefore, I would propose instead to specifically disable the SMP test that fails under current QEMU using a feature flag (like the one we use to detect whether we can exit on abort on x86), and leave the other tests that presumably work running. Aside from that, I'm okay with making |
I wasn't necessarily saying we wouldn't run the tests in CI, I was thinking about running them as a job which doesn't fail the whole CI if any test fails. But I'll investigate if disabling the SMP test is enough. |
According to #103, the current failure occurs when running the test |
Uh oh!
There was an error while loading. Please reload this page.
CI has been red for a while now, due to various problems. At this point, it's not very useful psychologically (does CI fail because the code is broken, or because of the well-known issue with QEMU?).
I propose some changes to the way we currently integrate new code into
uefi-rs
:master
branch protected, and only allow merging PRs with itbors
to ensure code onmaster
always compiles. Although at this point it seems unnecessary, we rarely have more than one PR at a time.cargo check
on all the crates - this will be required for mergingcargo fmt
- this will also be required for merging.Cc @HadrienG2
The text was updated successfully, but these errors were encountered: